code review 13468045: text/template: catch unmatched right delimiter

text/template: catch unmatched right delimiter
It was simply a missing error case: when scanning plain text
outside of an action, a right delimiter should be an error.

[r, 2013-09-12 03:12:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dsymonds, 2013-09-12 03:16:38]

LGTM

[r, 2013-09-12 03:23:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=f6ccb434acdd ***

text/template: catch unmatched right delimiter
It was simply a missing error case: when scanning plain text
outside of an action, a right delimiter should be an error.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/13468045

[tegoor_gmail.com, 2013-09-12 12:29:25]

This causes a lot of code is not compatible. 


On Thursday, September 12, 2013 11:23:07 AM UTC+8, r...@golang.org wrote:
>
> *** Submitted as 
> https://code.google.com/p/go/source/detail?r=f6ccb434acdd *** 
>
> text/template: catch unmatched right delimiter 
> It was simply a missing error case: when scanning plain text 
> outside of an action, a right delimiter should be an error. 
>
> R=golang-dev, dsymonds 
> CC=golang-dev 
> https://codereview.appspot.com/13468045 
>
>
> https://codereview.appspot.com/13468045/ 
>

[r, 2013-09-12 12:34:51]

Can you be more specific?

-rob

[tegoor_gmail.com, 2013-09-12 12:56:58]

When the template content include some minified javascript,  the error 
always appears.

On Thursday, September 12, 2013 8:34:28 PM UTC+8, Rob Pike wrote:
>
> Can you be more specific? 
>
> -rob 
>

[dsymonds, 2013-09-12 13:11:52]

If you are writing JavaScript directly into a template then you're going to
get all kinds of failures, even before this CL. Try changing the template
delimiters.

[r, 2013-09-12 22:13:58]

If minified JS can produce }} surely it can also produce {{. I agree
with David, this sounds scary. Use safe delimiters.

However, I will consider rolling back this change if a convincing case
can be made. It is a breaking change.

-rob