Issue 13464044: openpgp/packet: Compact UserAttribute subpacket lengths...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13464044: openpgp/packet: Compact UserAttribute subpacket lengths...

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by cmars

Modified:
10 years, 7 months ago

Reviewers:
agl1

CC:
golang-dev

Visibility:
Public.

Description

openpgp/packet: Compact UserAttribute subpacket lengths, fixes signatures. Necessary to reproduce the same hash for verifying a UserAttribute signature. Reuse and fix defect in serializeSubpacketLength, RFC 4880, Section 4.2.2.2.

Patch Set 1 #

Patch Set 2 : diff -r d2aa34003cbd https://code.google.com/p/go.crypto #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	openpgp/packet/opaque.go	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
	M	openpgp/packet/signature.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

*** Submitted as https://code.google.com/p/go/source/detail?r=1d2f9a3b9863&repo=crypto *** openpgp/packet: Compact UserAttribute subpacket lengths, fixes signatures. Necessary to reproduce ...

10 years, 7 months ago (2013-09-04 14:22:00 UTC) #2

agl1

10 years, 7 months ago (2013-09-04 14:22:33 UTC) #3

Seems like that data that triggered this would make a good test :)

Expand All Messages | Collapse All Messages