Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(577)

Issue 134600043: Limit looping in Grob::common_refpoint (issue 4079) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by eble
Modified:
9 years, 6 months ago
Reviewers:
Keith, pkx166h, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Limit looping in Grob::common_refpoint (issue 4079) This does not address the root cause, but it fails in a better way. -For those curious about the root cause, it does not appear to be any cycle in parentage within the range of the loop counter. That's all I know.- [Update: Actually, it might be. I realized didn't check it properly. But I do know that it wasn't as simple as something calling x->set_parent(x). I did check that.]

Patch Set 1 #

Patch Set 2 : Fix copyright date on new file #

Total comments: 1

Patch Set 3 : Set saner limits; indent; fix copyright #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
A flower/include/strict-counter.hh View 1 chunk +59 lines, -0 lines 5 comments Download
M lily/grob.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9
eble
9 years, 6 months ago (2014-09-07 00:49:11 UTC) #1
Keith
I would prefer to know what pattern of data makes this loop endless, but the ...
9 years, 6 months ago (2014-09-07 06:04:37 UTC) #2
dak
I don't like it. The maximum range of a variable is an arbitrary value and ...
9 years, 6 months ago (2014-09-07 06:20:59 UTC) #3
eble
On 2014/09/07 06:20:59, dak wrote: > I don't like it. The maximum range of a ...
9 years, 6 months ago (2014-09-07 13:15:18 UTC) #4
eble
Set saner limits, fixed indentation and copyright notice. I have disregarded Mike Solomon's suggestion to ...
9 years, 6 months ago (2014-09-08 23:46:14 UTC) #5
pkx166h
Passes make, make check and a full make doc but the reg tests show numerous ...
9 years, 6 months ago (2014-09-10 11:51:52 UTC) #6
dak
https://codereview.appspot.com/134600043/diff/40001/flower/include/strict-counter.hh File flower/include/strict-counter.hh (right): https://codereview.appspot.com/134600043/diff/40001/flower/include/strict-counter.hh#newcode30 flower/include/strict-counter.hh:30: T MINIMUM = std::numeric_limits<T>::min (), Is there a point ...
9 years, 6 months ago (2014-09-10 12:35:15 UTC) #7
dak
Frankly, I think it makes no sense to create some "abstraction" in the flower pseudolibrary ...
9 years, 6 months ago (2014-09-10 12:46:14 UTC) #8
eble
9 years, 6 months ago (2014-09-10 13:19:24 UTC) #9
I do not intend to address the remaining issues with this patch.  I thought it
would be a quick way to mitigate the looping and might be useful in other
places, but clearly mitigation is valued at almost nothing, and I need to focus
on other things.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b