Render Bundles

Render Bundles

Re-propose of render bundles with additional changes requested
during feedback. This has some additional better testing around
the bundle module and lays out the pattern for a later refactoring
to try and share more code between Service and Bundle modules down the
road as we have time.

https://code.launchpad.net/~bcsaller/juju-gui/renderBundles3/+merge/183287

(do not edit description out of merge proposal)

[bcsaller, 2013-08-30 21:48:25]

Please take a look.

[benjamin.saller, 2013-08-30 21:49:53]

The previous version at https://codereview.appspot.com/13361043/ already has a
+1, need one more, most likely from rick who has the feedback asking for some of
the changes here.

[rharding, 2013-08-31 03:31:08]

LGTM with trivial

https://codereview.appspot.com/13447043/diff/1/app/views/topology/bundle.js
File app/views/topology/bundle.js (right):

https://codereview.appspot.com/13447043/diff/1/app/views/topology/bundle.js#n...
app/views/topology/bundle.js:330: @method panToCenter
match earlier comments, two spaces, closing */ back a bit.

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:63: 
comments alignment

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:463: ZP = '.zoom-plane',
extra space not required here

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:497: yuiNode = Y.Node(node);
same

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:516: box = d3.select(node).datum();
extra space

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1143: Pans the environment view to the center all
the services on the canvas.
now there's no space before the text

https://codereview.appspot.com/13447043/diff/1/docs/d3-component-framework.rst
File docs/d3-component-framework.rst (right):

https://codereview.appspot.com/13447043/diff/1/docs/d3-component-framework.rs...
docs/d3-component-framework.rst:122: attribute which defaults to true. When
false events will not be bound and this
When false <add comma>

[benjamin.saller, 2013-09-01 11:57:42]

Thanks for the review, followed up on all this, as noted by errors introduced by
make prep, not design.

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:63: 
On 2013/08/31 03:31:08, rharding wrote:
> comments alignment 

Whole classes of errors introduced by make prep, I thought things were basically
working but it sometimes shifts things around without me noticing, thanks.

[bcsaller, 2013-09-01 12:03:31]

*** Submitted:

Render Bundles

Re-propose of render bundles with additional changes requested
during feedback. This has some additional better testing around
the bundle module and lays out the pattern for a later refactoring
to try and share more code between Service and Bundle modules down the
road as we have time.

R=benjamin.saller, rharding
CC=
https://codereview.appspot.com/13447043