Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(601)

Issue 13443044: Add boolean/checkbox support to databinding.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rharding
Modified:
10 years, 6 months ago
Reviewers:
benjamin.saller, mp+183694
Visibility:
Public.

Description

Add boolean/checkbox support to databinding. - Get/Set of a checkbox value works through the node.get('checked') vs 'value' attr. - Add a test to verify it binds to the model. https://code.launchpad.net/~rharding/juju-gui/checkbox-binding/+merge/183694 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add boolean/checkbox support to databinding. #

Patch Set 3 : Add boolean/checkbox support to databinding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/databinding.js View 2 chunks +18 lines, -1 line 0 comments Download
M test/test_databinding.js View 1 6 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 6 months ago (2013-09-03 15:34:08 UTC) #1
rharding
Please take a look. https://codereview.appspot.com/13443044/diff/1/app/views/databinding.js File app/views/databinding.js (right): https://codereview.appspot.com/13443044/diff/1/app/views/databinding.js#newcode43 app/views/databinding.js:43: if (value === 'false' || ...
10 years, 6 months ago (2013-09-03 15:41:38 UTC) #2
benjamin.saller
LGTM thanks
10 years, 6 months ago (2013-09-03 15:45:13 UTC) #3
rharding
10 years, 6 months ago (2013-09-03 15:54:49 UTC) #4
*** Submitted:

Add boolean/checkbox support to databinding.

- Get/Set of a checkbox value works through the node.get('checked') vs 'value'
attr.
- Add a test to verify it binds to the model.

R=benjamin.saller
CC=
https://codereview.appspot.com/13443044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b