Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(312)

Issue 13438043: code review 13438043: go.crypto/ssh/test: Only show SSHD debug output if test... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by hanwen-google
Modified:
10 years, 6 months ago
Reviewers:
CC:
agl1, dfc, jpsugar, golang-dev
Visibility:
Public.

Description

go.crypto/ssh/test: Only show SSHD debug output if test fails.

Patch Set 1 #

Patch Set 2 : diff -r 8cbc665c1b38 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 8cbc665c1b38 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 8cbc665c1b38 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 8cbc665c1b38 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M ssh/test/test_unix_test.go View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7
hanwen-google
Hello agl1, dfc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 7 months ago (2013-08-30 18:16:30 UTC) #1
hanwen-google
(I don't quite understand why this doesn't work if you set cmd.Stderr to s.output directly)
10 years, 7 months ago (2013-08-30 18:26:54 UTC) #2
jpsugar
On 2013/08/30 18:26:54, hanwen wrote: > (I don't quite understand why this doesn't work if ...
10 years, 7 months ago (2013-08-30 18:44:45 UTC) #3
jpsugar
On 2013/08/30 18:44:45, jpsugar wrote: > Because sshd has subprocesses that process.Kill() isn't reaching, so ...
10 years, 7 months ago (2013-08-30 18:46:39 UTC) #4
hanwen-google
On 2013/08/30 18:46:39, jpsugar wrote: > On 2013/08/30 18:44:45, jpsugar wrote: > > Because sshd ...
10 years, 7 months ago (2013-09-02 12:07:53 UTC) #5
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=d2aa34003cbd&repo=crypto *** go.crypto/ssh/test: Only show SSHD debug output if test fails. R=agl, ...
10 years, 6 months ago (2013-09-03 14:54:29 UTC) #6
hanwen-google
10 years, 6 months ago (2013-09-03 15:01:49 UTC) #7
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b