Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 134360043: code review 134360043: runtime: increase windows prof thread priority sooner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by brainman
Modified:
10 years, 6 months ago
Reviewers:
gobot, dvyukov
CC:
golang-codereviews, dvyukov
Visibility:
Public.

Description

runtime: increase windows prof thread priority sooner If system is busy burning cpu, it takes long time (about 300ms on windows builders) to adjust prof thread priority. Once adjusted, prof thread runs ahead of everyone else, but due to initial slowness, it does not capture prof snapshots until start-up period is completed. Change prof thread priority sooner, so it can start captures straight away.

Patch Set 1 #

Patch Set 2 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/runtime/os_windows.c View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2014-09-03 02:46:05 UTC) #1
dvyukov
LGTM I would even do it both places. The thread that calls setcpuprofilerate can exhaust ...
10 years, 6 months ago (2014-09-03 03:33:39 UTC) #2
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=2008238cdc04 *** runtime: increase windows prof thread priority sooner If system is ...
10 years, 6 months ago (2014-09-03 04:17:11 UTC) #3
brainman
On 2014/09/03 03:33:39, dvyukov wrote: > ... > I would even do it both places. ...
10 years, 6 months ago (2014-09-03 04:17:35 UTC) #4
gobot
10 years, 6 months ago (2014-09-03 04:20:54 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-race-temp builder.
See http://build.golang.org/log/c0ee8f3e5c4d7b978acf229b2e6bff20f16271d3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b