moin-1.9 - Missing email notification types.

moin-1.9 - Missing email notification types.

[Thomas.J.Waldmann, 2013-08-30 14:46:13]

looks good, just need to think about good names.

https://codereview.appspot.com/13429043/diff/1/MoinMoin/events/emailnotify.py
File MoinMoin/events/emailnotify.py (right):

https://codereview.appspot.com/13429043/diff/1/MoinMoin/events/emailnotify.py...
MoinMoin/events/emailnotify.py:129: def handle_file(event, fileaction):
maybe we need to think about a better name instead of fileaction.

maybe msg_formatter ?

[Thomas.J.Waldmann, 2013-10-16 03:33:48]

also please try all the new code manually and run the automated unittests also.

https://codereview.appspot.com/13429043/diff/11001/MoinMoin/PageEditor.py
File MoinMoin/PageEditor.py (right):

https://codereview.appspot.com/13429043/diff/11001/MoinMoin/PageEditor.py#new...
MoinMoin/PageEditor.py:695: e = PageRevertedEvent(self.request, self, revision,
revstr, comment)
hmm, you are giving a Page(Editor) object as 2nd param, is that working ok with
the event system?

https://codereview.appspot.com/13429043/diff/11001/MoinMoin/events/__init__.py
File MoinMoin/events/__init__.py (right):

https://codereview.appspot.com/13429043/diff/11001/MoinMoin/events/__init__.p...
MoinMoin/events/__init__.py:142: def __init__(self, request, page, previous,
current, comment=""):
somehow the signature of this doesn't match the params it is fed with.

https://codereview.appspot.com/13429043/diff/11001/MoinMoin/events/emailnotif...
File MoinMoin/events/emailnotify.py (right):

https://codereview.appspot.com/13429043/diff/11001/MoinMoin/events/emailnotif...
MoinMoin/events/emailnotify.py:23: def prep_page_changed_mail(request, page,
comment, email_lang, revisions, trivial, revert):
as you require a new param that has no default:

did you fix all places where it is called?

[PriceChild, 2013-10-16 14:57:02]

https://codereview.appspot.com/13429043/diff/1/MoinMoin/events/emailnotify.py
File MoinMoin/events/emailnotify.py (right):

https://codereview.appspot.com/13429043/diff/1/MoinMoin/events/emailnotify.py...
MoinMoin/events/emailnotify.py:129: def handle_file(event, fileaction):
On 2013/08/30 14:46:13, Thomas.J.Waldmann wrote:
> maybe we need to think about a better name instead of fileaction.
> 
> maybe msg_formatter ?

Done.