Issue 13426045: api(server)/uniter: Added DestroyAllSubordinates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13426045: api(server)/uniter: Added DestroyAllSubordinates (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dimitern

Modified:
10 years, 8 months ago

Reviewers:
mp+183474, fwereade

Visibility:
Public.

Description

api(server)/uniter: Added DestroyAllSubordinates Because the uniter needs to remove both the (principal) unit it's running with, and any of its subordinates, this change was needed. Added a new API call: DestroyAllSubordinates(), as agreed online. We need to change the uniter code to use it instead of Destroy() when dealing with subordinates (uniter/modes.go:298), so added a TODO for that. https://code.launchpad.net/~dimitern/juju-core/113-api-uniter-unit-destroy-fix/+merge/183474 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : api(server)/uniter: Added DestroyAllSubordinates #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -8 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/uniter/unit.go	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	state/api/uniter/uniter_test.go	View		2 chunks	+28 lines, -8 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View		1 chunk	+37 lines, -0 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	worker/uniter/modes.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM, sorry delay https://codereview.appspot.com/13426045/diff/1/state/apiserver/uniter/uniter_test.go File state/apiserver/uniter/uniter_test.go (right): https://codereview.appspot.com/13426045/diff/1/state/apiserver/uniter/uniter_test.go#newcode592 state/apiserver/uniter/uniter_test.go:592: // Verify wordpressUnit's subordinates were destroyed ...

10 years, 8 months ago (2013-09-02 14:49:00 UTC) #2

dimitern

10 years, 8 months ago (2013-09-02 15:01:33 UTC) #3

Please take a look.

https://codereview.appspot.com/13426045/diff/1/state/apiserver/uniter/uniter_...
File state/apiserver/uniter/uniter_test.go (right):

https://codereview.appspot.com/13426045/diff/1/state/apiserver/uniter/uniter_...
state/apiserver/uniter/uniter_test.go:592: // Verify wordpressUnit's
subordinates were destroyed and removed.
On 2013/09/02 14:49:00, fwereade wrote:
> s/ and removed//

Done.

Expand All Messages | Collapse All Messages