Issue 13424043: Enable sandbox mode in juju-core environments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13424043: Enable sandbox mode in juju-core environments.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by frankban

Modified:
10 years, 8 months ago

Reviewers:
rharding, mp+183124

Visibility:
Public.

Description

Enable sandbox mode in juju-core environments. Also added a sandbox functional test and improved the backend framework unit tests. https://code.launchpad.net/~frankban/charms/precise/juju-gui/enable-go-sandbox/+merge/183124 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Enable sandbox mode in juju-core environments. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -58 lines)			Patch
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/backend.py	View	1 chunk	+9 lines, -14 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/20-functional.test	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/test_backends.py	View	3 chunks	+67 lines, -42 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

frankban

*** Submitted: Enable sandbox mode in juju-core environments. Also added a sandbox functional test and ...

10 years, 8 months ago (2013-08-30 13:18:04 UTC) #3

Thank you for the review!

Expand All Messages | Collapse All Messages