Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1297)

Issue 13422044: code review 13422044: net: re-enable raw socket tests on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by brainman
Modified:
6 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, mikio, rsc
Visibility:
Public.

Description

net: re-enable raw socket tests on windows Since CL 38bf89161a72 raw socket tests are not executed on windows builders. This change re-enable them again. It will attempt to run raw socket tests only if user is permitted to create raw socket by OS. Fixes issue 6392

Patch Set 1 #

Patch Set 2 : diff -r 84975e4930dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 84975e4930dd https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 411ac795f84e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -50 lines) Patch
M src/pkg/net/fd_plan9.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/net/fd_unix.go View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/net/fd_windows.go View 1 1 chunk +19 lines, -0 lines 0 comments Download
M src/pkg/net/ipraw_test.go View 1 3 chunks +12 lines, -22 lines 0 comments Download
M src/pkg/net/multicast_test.go View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/pkg/net/packetconn_test.go View 1 1 chunk +2 lines, -13 lines 0 comments Download
M src/pkg/net/protoconn_test.go View 1 1 chunk +2 lines, -11 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
brainman
Hello golang-dev@googlegroups.com (cc: mikioh.mikioh@gmail.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 8 months ago (2013-09-18 06:46:53 UTC) #1
rsc
LGTM
6 years, 8 months ago (2013-09-23 17:36:56 UTC) #2
brainman
6 years, 8 months ago (2013-09-24 03:15:57 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=7464c57d4ccd ***

net: re-enable raw socket tests on windows

Since CL 38bf89161a72 raw socket tests are not executed
on windows builders. This change re-enable them again.
It will attempt to run raw socket tests only if user
is permitted to create raw socket by OS.

Fixes issue 6392

R=golang-dev
CC=golang-dev, mikioh.mikioh, rsc
https://codereview.appspot.com/13422044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b