Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 13421050: environs: add Environs.Config method

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
mp+185861, gz
Visibility:
Public.

Description

environs: add Environs.Config method Also remove almost-never-used Environs.Open method, clean up the places that were calling it, and add tests for currently untested functions in environs. The apparently lost test coverage in the providers is actually covered adequately in the environs/config tests. https://code.launchpad.net/~rogpeppe/juju-core/398-move-config-for-name/+merge/185861 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add Environs.Config method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -142 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config.go View 2 chunks +21 lines, -0 lines 0 comments Download
M environs/config_test.go View 8 chunks +26 lines, -31 lines 0 comments Download
M environs/open.go View 1 chunk +7 lines, -40 lines 0 comments Download
M environs/open_test.go View 1 chunk +85 lines, -10 lines 0 comments Download
M provider/ec2/config_test.go View 4 chunks +9 lines, -31 lines 0 comments Download
M provider/openstack/config_test.go View 5 chunks +10 lines, -30 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
10 years, 7 months ago (2013-09-16 16:45:23 UTC) #1
gz
10 years, 7 months ago (2013-09-16 16:51:23 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b