Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 13421049: code review 13421049: net: make all.bat run for ordinary Windows users (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rsc
Modified:
11 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: make all.bat run for ordinary Windows users This CL is required for all.bat to work out of the box on my Windows 8 laptop. These tests either require the firewall to be turned off or require the user to be in the Administrators group. I don't know which. Alex may follow up with a refinement of the test to allow them to run if the user is in the Administrators group. Fixes issue 6392.

Patch Set 1 #

Patch Set 2 : diff -r 589bcd9dd528 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 589bcd9dd528 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c2779374f662 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/pkg/net/ipraw_test.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/pkg/net/multicast_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/net/packetconn_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/net/protoconn_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2013-09-16 15:11:25 UTC) #1
bradfitz
LGTM On Mon, Sep 16, 2013 at 4:11 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 6 months ago (2013-09-16 15:12:07 UTC) #2
rsc
11 years, 6 months ago (2013-09-16 18:05:08 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=38bf89161a72 ***

net: make all.bat run for ordinary Windows users

This CL is required for all.bat to work out of the box on
my Windows 8 laptop.

These tests either require the firewall to be turned off
or require the user to be in the Administrators group.
I don't know which.

Alex may follow up with a refinement of the test to
allow them to run if the user is in the Administrators
group.

Fixes issue 6392.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13421049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b