code review 13421049: net: make all.bat run for ordinary Windows users

net: make all.bat run for ordinary Windows users

This CL is required for all.bat to work out of the box on
my Windows 8 laptop.

These tests either require the firewall to be turned off
or require the user to be in the Administrators group.
I don't know which.

Alex may follow up with a refinement of the test to
allow them to run if the user is in the Administrators
group.

Fixes issue 6392.

[rsc, 2013-09-16 15:11:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-09-16 15:12:07]

LGTM



On Mon, Sep 16, 2013 at 4:11 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net: make all.bat run for ordinary Windows users
>
> This CL is required for all.bat to work out of the box on
> my Windows 8 laptop.
>
> These tests either require the firewall to be turned off
> or require the user to be in the Administrators group.
> I don't know which.
>
> Alex may follow up with a refinement of the test to
> allow them to run if the user is in the Administrators
> group.
>
> Fixes issue 6392.
>
> Please review this at
https://codereview.appspot.**com/13421049/<https://codereview.appspot.com/134...
>
> Affected files (+16, -0 lines):
>   M src/pkg/net/ipraw_test.go
>   M src/pkg/net/multicast_test.go
>   M src/pkg/net/packetconn_test.go
>   M src/pkg/net/protoconn_test.go
>
>
> Index: src/pkg/net/ipraw_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/ipraw_test.go
> +++ b/src/pkg/net/ipraw_test.go
> @@ -84,6 +84,9 @@
>         case "plan9":
>                 t.Skipf("skipping test on %q", runtime.GOOS)
>         case "windows":
> +               if testing.Short() || !*testExternal {
> +                       t.Skipf("skipping test on %q to avoid network
> firewall", runtime.GOOS)
> +               }
>         default:
>                 if os.Getuid() != 0 {
>                         t.Skip("skipping test; must be root")
> @@ -158,6 +161,9 @@
>         case "plan9":
>                 t.Skipf("skipping test on %q", runtime.GOOS)
>         case "windows":
> +               if testing.Short() || !*testExternal {
> +                       t.Skipf("skipping test on %q to avoid network
> firewall", runtime.GOOS)
> +               }
>         default:
>                 if os.Getuid() != 0 {
>                         t.Skip("skipping test; must be root")
> Index: src/pkg/net/multicast_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/multicast_test.**go
> +++ b/src/pkg/net/multicast_test.**go
> @@ -25,6 +25,10 @@
>  // port.
>  func TestIPv4MulticastListener(t *testing.T) {
>         switch runtime.GOOS {
> +       case "windows":
> +               if testing.Short() || !*testExternal {
> +                       t.Skipf("skipping test on %q to avoid network
> firewall", runtime.GOOS)
> +               }
>         case "plan9":
>                 t.Skipf("skipping test on %q", runtime.GOOS)
>         }
> Index: src/pkg/net/packetconn_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/packetconn_test.**go
> +++ b/src/pkg/net/packetconn_test.**go
> @@ -32,6 +32,9 @@
>                                 t.Logf("skipping %q test on %q", net,
> runtime.GOOS)
>                         }
>                 case "windows":
> +                       if testing.Short() || !*testExternal {
> +                               t.Skipf("skipping test on %q to avoid
> network firewall", runtime.GOOS)
> +                       }
>                 default:
>                         if os.Getuid() != 0 {
>                                 return nil, func() {
> Index: src/pkg/net/protoconn_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/protoconn_test.**go
> +++ b/src/pkg/net/protoconn_test.**go
> @@ -177,6 +177,9 @@
>         case "plan9":
>                 t.Skipf("skipping test on %q", runtime.GOOS)
>         case "windows":
> +               if testing.Short() || !*testExternal {
> +                       t.Skipf("skipping test on %q to avoid network
> firewall", runtime.GOOS)
> +               }
>         default:
>                 if os.Getuid() != 0 {
>                         t.Skipf("skipping test; must be root")
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-16 18:05:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=38bf89161a72 ***

net: make all.bat run for ordinary Windows users

This CL is required for all.bat to work out of the box on
my Windows 8 laptop.

These tests either require the firewall to be turned off
or require the user to be in the Administrators group.
I don't know which.

Alex may follow up with a refinement of the test to
allow them to run if the user is in the Administrators
group.

Fixes issue 6392.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13421049