Issue 134210043: code review 134210043: archive/zip: add Writer.Flush

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 134210043: code review 134210043: archive/zip: add Writer.Flush (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by bradfitz

Modified:
10 years, 8 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

archive/zip: add Writer.Flush This is needed for callers to be able to keep track of the writing position within a zip file. Otherwise it's not possible to compute the size of headers, and the TOC isn't written until the very end.

Patch Set 1 #

Patch Set 2 : diff -r 7786bd1553ab00632e8ea85a78d640eb19c9d490 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7786bd1553ab00632e8ea85a78d640eb19c9d490 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 84626d6e9a4815c47da94317f4b46c876ab0fb84 https://go.googlecode.com/hg/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/pkg/archive/zip/writer.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/pkg/archive/zip/writer_test.go	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 8 months ago (2014-09-01 04:00:00 UTC) #1

bradfitz

10 years, 8 months ago (2014-09-01 04:32:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=afc7e22420ce ***

archive/zip: add Writer.Flush

This is needed for callers to be able to keep track of the
writing position within a zip file. Otherwise it's not
possible to compute the size of headers, and the TOC isn't
written until the very end.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/134210043

Expand All Messages | Collapse All Messages