Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 134200044: code review 134200044: runtime: convert traceback*.c to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
r
CC:
golang-codereviews, remyoudompheng, dave_cheney.net, r, dvyukov, iant, khr
Visibility:
Public.

Description

runtime: convert traceback*.c to Go The two converted files were nearly identical. Instead of continuing that duplication, I merged them into a single traceback.go. Tested on arm, amd64, amd64p32, and 386.

Patch Set 1 #

Patch Set 2 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 17b5fc2aa130ef7c32cbbdf95620862610d7773e https://code.google.com/p/go/ #

Total comments: 1

Patch Set 9 : diff -r df0572446e37549332e1d1154955409e2cff6008 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 10 : diff -r df0572446e37549332e1d1154955409e2cff6008 https://code.google.com/p/go/ #

Patch Set 11 : diff -r df0572446e37549332e1d1154955409e2cff6008 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -690 lines) Patch
M src/cmd/api/goapi.go View 1 2 3 4 5 6 7 1 chunk +24 lines, -7 lines 0 comments Download
M src/pkg/runtime/extern.go View 1 2 3 4 5 6 7 8 4 chunks +8 lines, -16 lines 0 comments Download
M src/pkg/runtime/heapdump.c View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -2 lines 0 comments Download
M src/pkg/runtime/mprof.go View 1 3 chunks +5 lines, -5 lines 0 comments Download
A src/pkg/runtime/os_windows_386.go View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
A src/pkg/runtime/os_windows_amd64.go View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/runtime/stack.c View 1 5 chunks +9 lines, -3 lines 0 comments Download
M src/pkg/runtime/stubs.go View 1 2 3 4 5 6 7 8 3 chunks +19 lines, -1 line 0 comments Download
M src/pkg/runtime/traceback.go View 1 2 3 4 5 6 7 8 9 10 4 chunks +356 lines, -288 lines 0 comments Download
R src/pkg/runtime/traceback_arm.c View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -363 lines 0 comments Download
A src/pkg/runtime/traceback_windows.go View 1 2 3 4 5 6 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 9
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...
10 years, 6 months ago (2014-09-02 03:58:34 UTC) #1
remyoudompheng
https://codereview.appspot.com/134200044/diff/140001/src/pkg/runtime/extern.go File src/pkg/runtime/extern.go (right): https://codereview.appspot.com/134200044/diff/140001/src/pkg/runtime/extern.go#newcode146 src/pkg/runtime/extern.go:146: return int(callers(skip, &pc[0], len(pc))) callers now returns int
10 years, 6 months ago (2014-09-02 05:24:05 UTC) #2
dave_cheney.net
Is it safe to use the address of the empty struct as a signal to ...
10 years, 6 months ago (2014-09-02 06:04:54 UTC) #3
rsc
> https://codereview.appspot.com/134200044/diff/140001/src/pkg/runtime/extern.go#newcode146 > src/pkg/runtime/extern.go:146: return int(callers(skip, &pc[0], len(pc))) > callers now returns int thanks
10 years, 6 months ago (2014-09-02 18:09:30 UTC) #4
rsc
On 2014/09/02 06:04:54, dfc wrote: > Is it safe to use the address of the ...
10 years, 6 months ago (2014-09-02 18:10:55 UTC) #5
rsc
fyi, now with side-by-side diffs in traceback.go
10 years, 6 months ago (2014-09-02 18:38:24 UTC) #6
r
LGTM https://codereview.appspot.com/134200044/diff/160001/src/pkg/runtime/traceback.go File src/pkg/runtime/traceback.go (right): https://codereview.appspot.com/134200044/diff/160001/src/pkg/runtime/traceback.go#newcode31 src/pkg/runtime/traceback.go:31: const usesLR = GOARCH == "arm" this definition ...
10 years, 6 months ago (2014-09-02 18:49:17 UTC) #7
rsc
https://codereview.appspot.com/134200044/diff/160001/src/pkg/runtime/traceback.go File src/pkg/runtime/traceback.go (right): https://codereview.appspot.com/134200044/diff/160001/src/pkg/runtime/traceback.go#newcode330 src/pkg/runtime/traceback.go:330: print(hex(argp[i])) On 2014/09/02 18:49:17, r wrote: > is i ...
10 years, 6 months ago (2014-09-02 19:07:09 UTC) #8
rsc
10 years, 6 months ago (2014-09-02 19:13:00 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=3a55fc3ede26 ***

runtime: convert traceback*.c to Go

The two converted files were nearly identical.
Instead of continuing that duplication, I merged them
into a single traceback.go.

Tested on arm, amd64, amd64p32, and 386.

LGTM=r
R=golang-codereviews, remyoudompheng, dave, r
CC=dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/134200044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b