Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(333)

Issue 134200043: code review 134200043: runtime: paste mprof.goc into mprof.go as comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rsc
Modified:
10 years, 8 months ago
Reviewers:
gobot, bradfitz
CC:
golang-codereviews, bradfitz, iant, khr, r
Visibility:
Public.

Description

runtime: paste mprof.goc into mprof.go as comments NO CODE CHANGES HERE The first conversion was not complete. This CL doesn't make any actual changes, but it inserts the missing mprof.goc code as comments so that the next CL will have useful diffs. To make the diffs a bit more useful, removed all semicolons, ->, and runtimeĀ· prefixes as well. Also corrected order of a few functions in mprof.go to match original order in mprof.goc.

Patch Set 1 #

Patch Set 2 : diff -r a4312ec25ccd4f767ee37be56697cfabc7b3aaa4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a4312ec25ccd4f767ee37be56697cfabc7b3aaa4 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f22bbbdf0c3616672c0a04ede7a245695aeff547 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -40 lines) Patch
M src/pkg/runtime/mprof.go View 1 2 5 chunks +384 lines, -40 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, khr, r), I'd like you to review this change to https://code.google.com/p/go/
10 years, 8 months ago (2014-09-01 02:35:18 UTC) #1
bradfitz
LGTM
10 years, 8 months ago (2014-09-01 03:35:06 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=84626d6e9a48 *** runtime: paste mprof.goc into mprof.go as comments NO CODE CHANGES ...
10 years, 8 months ago (2014-09-01 04:06:29 UTC) #3
gobot
10 years, 8 months ago (2014-09-01 04:14:25 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/8192d0fdf73a606cd90b0ff3979857fcd4ed4cba
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b