Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(373)

Issue 13416045: compress/flate: reduce allocations

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by bradfitz
Modified:
6 years, 2 months ago
Reviewers:
rsc
Visibility:
Public.

Description

compress/flate: reduce allocations benchmark old ns/op new ns/op delta BenchmarkGunzip 8628248473 8509271514 -1.38% benchmark old allocs new allocs delta BenchmarkGunzip 209831 172185 -17.94% benchmark old bytes new bytes delta BenchmarkGunzip 579662000 300007152 -48.24% Update Issue 6317

Patch Set 1 #

Patch Set 2 : diff -r 6b0ef65315eb https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -16 lines) Patch
M src/pkg/compress/flate/inflate.go View 1 9 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 1
rsc
6 years, 2 months ago (2013-12-18 02:42:23 UTC) #1
not lgtm

we went through this with bufio. 
no recycling behind the scenes. use Reset methods.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b