Issue 13413050: code review 13413050: crypto/tls: fix TLS 1.2 client certificates.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13413050: code review 13413050: crypto/tls: fix TLS 1.2 client certificates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by agl1

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/tls: fix TLS 1.2 client certificates. With TLS 1.2, when sending client certificates the code was omitting the new (in TLS 1.2) signature and hash fields.

Patch Set 1 #

Patch Set 2 : diff -r 45343b9c3db4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 45343b9c3db4 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ba59b8968248 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+582 lines, -11 lines)			Patch
M	src/pkg/crypto/tls/handshake_client.go	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_client_test.go	View	1	2 chunks	+564 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/tls/prf.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-09-16 15:31:48 UTC) #1

agl1

11 years, 7 months ago (2013-09-16 20:40:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4db3c8daee96 ***

crypto/tls: fix TLS 1.2 client certificates.

With TLS 1.2, when sending client certificates the code was omitting
the new (in TLS 1.2) signature and hash fields.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13413050

Expand All Messages | Collapse All Messages