Issue 134020043: code review 134020043: cmd/internal/objfile: fix dissassembly of Plan 9 object...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 134020043: code review 134020043: cmd/internal/objfile: fix dissassembly of Plan 9 object... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by ality

Modified:
10 years, 8 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

cmd/internal/objfile: fix dissassembly of Plan 9 object files This is a reapplication of CL 93520045 (changeset 5012df7fac58) since that was lost during the move to an internal package.

Patch Set 1 #

Patch Set 2 : diff -r 1b4900565b48d0f03f4f5263116b688fbeed75f8 https://code.google.com/p/go #

Patch Set 3 : diff -r 1b4900565b48d0f03f4f5263116b688fbeed75f8 https://code.google.com/p/go #

Patch Set 4 : diff -r dc2e57159715f11284ce12320e66525579010758 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	src/cmd/internal/objfile/plan9obj.go	View	1	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2014-08-28 08:04:58 UTC) #1

ality

10 years, 8 months ago (2014-08-28 23:01:48 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a18b0167683f ***

cmd/internal/objfile: fix dissassembly of Plan 9 object files

This is a reapplication of CL 93520045 (changeset 5012df7fac58)
since that was lost during the move to an internal package.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/134020043

Expand All Messages | Collapse All Messages