Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2580)

Issue 13401050: worker;cmd/jujud: Replace uniter with apiuniter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dimitern
Modified:
10 years, 7 months ago
Reviewers:
mp+185322, rog
Visibility:
Public.

Description

worker;cmd/jujud: Replace uniter with apiuniter Uniter worker now uses only the API and the unit agent was changed as needed to accomodate this. Code in worker/apiuniter, which was already reviewed before replaced the corresponding parts in worker/uniter, so we can keep the history of the old uniter source. Also, worker/apiuniter was completely deleted as it's no longer needed. Live tested with the local provider and the same test used before - it all seems to work fine: relation settings caching, deploying/recalling subordinates, etc. With this, the uniter state-to-API migration is complete. https://code.launchpad.net/~dimitern/juju-core/135-replace-uniter-with-apiuniter/+merge/185322 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker;cmd/jujud: Replace uniter with apiuniter #

Patch Set 3 : worker;cmd/jujud: Replace uniter with apiuniter #

Patch Set 4 : worker;cmd/jujud: Replace uniter with apiuniter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -12033 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/unit.go View 1 2 1 chunk +5 lines, -17 lines 0 comments Download
M cmd/jujud/unit_test.go View 1 chunk +0 lines, -1 line 0 comments Download
D worker/apiuniter/charm/charm.go View 1 chunk +0 lines, -108 lines 0 comments Download
D worker/apiuniter/charm/charm_test.go View 1 chunk +0 lines, -160 lines 0 comments Download
D worker/apiuniter/charm/deployer.go View 1 chunk +0 lines, -210 lines 0 comments Download
D worker/apiuniter/charm/deployer_test.go View 1 chunk +0 lines, -224 lines 0 comments Download
D worker/apiuniter/charm/export_test.go View 1 chunk +0 lines, -14 lines 0 comments Download
D worker/apiuniter/charm/git.go View 1 chunk +0 lines, -224 lines 0 comments Download
D worker/apiuniter/charm/git_test.go View 1 chunk +0 lines, -241 lines 0 comments Download
D worker/apiuniter/context.go View 1 chunk +0 lines, -386 lines 0 comments Download
D worker/apiuniter/context_test.go View 1 chunk +0 lines, -735 lines 0 comments Download
D worker/apiuniter/debug/client.go View 1 chunk +0 lines, -120 lines 0 comments Download
D worker/apiuniter/debug/client_test.go View 1 chunk +0 lines, -47 lines 0 comments Download
D worker/apiuniter/debug/common.go View 1 chunk +0 lines, -35 lines 0 comments Download
D worker/apiuniter/debug/common_test.go View 1 chunk +0 lines, -30 lines 0 comments Download
D worker/apiuniter/debug/server.go View 1 chunk +0 lines, -116 lines 0 comments Download
D worker/apiuniter/debug/server_test.go View 1 2 3 1 chunk +0 lines, -206 lines 0 comments Download
D worker/apiuniter/filter.go View 1 chunk +0 lines, -552 lines 0 comments Download
D worker/apiuniter/filter_test.go View 1 chunk +0 lines, -475 lines 0 comments Download
D worker/apiuniter/hook/hook.go View 1 chunk +0 lines, -43 lines 0 comments Download
D worker/apiuniter/hook/hook_test.go View 1 chunk +0 lines, -61 lines 0 comments Download
D worker/apiuniter/jujuc/config-get.go View 1 chunk +0 lines, -77 lines 0 comments Download
D worker/apiuniter/jujuc/config-get_test.go View 1 chunk +0 lines, -178 lines 0 comments Download
D worker/apiuniter/jujuc/context.go View 1 chunk +0 lines, -133 lines 0 comments Download
D worker/apiuniter/jujuc/juju-log.go View 1 chunk +0 lines, -69 lines 0 comments Download
D worker/apiuniter/jujuc/juju-log_test.go View 1 chunk +0 lines, -99 lines 0 comments Download
D worker/apiuniter/jujuc/ports.go View 1 chunk +0 lines, -104 lines 0 comments Download
D worker/apiuniter/jujuc/ports_test.go View 1 chunk +0 lines, -111 lines 0 comments Download
D worker/apiuniter/jujuc/relation-get.go View 1 chunk +0 lines, -102 lines 0 comments Download
D worker/apiuniter/jujuc/relation-get_test.go View 1 chunk +0 lines, -264 lines 0 comments Download
D worker/apiuniter/jujuc/relation-ids.go View 1 chunk +0 lines, -68 lines 0 comments Download
D worker/apiuniter/jujuc/relation-ids_test.go View 1 chunk +0 lines, -157 lines 0 comments Download
D worker/apiuniter/jujuc/relation-list.go View 1 chunk +0 lines, -60 lines 0 comments Download
D worker/apiuniter/jujuc/relation-list_test.go View 1 chunk +0 lines, -173 lines 0 comments Download
D worker/apiuniter/jujuc/relation-set.go View 1 chunk +0 lines, -72 lines 0 comments Download
D worker/apiuniter/jujuc/relation-set_test.go View 1 chunk +0 lines, -225 lines 0 comments Download
D worker/apiuniter/jujuc/server.go View 1 chunk +0 lines, -183 lines 0 comments Download
D worker/apiuniter/jujuc/server_test.go View 1 chunk +0 lines, -219 lines 0 comments Download
D worker/apiuniter/jujuc/unit-get.go View 1 chunk +0 lines, -61 lines 0 comments Download
D worker/apiuniter/jujuc/unit-get_test.go View 1 chunk +0 lines, -92 lines 0 comments Download
D worker/apiuniter/jujuc/util_test.go View 1 chunk +0 lines, -198 lines 0 comments Download
D worker/apiuniter/modes.go View 1 chunk +0 lines, -421 lines 0 comments Download
D worker/apiuniter/relation/hookqueue.go View 1 chunk +0 lines, -390 lines 0 comments Download
D worker/apiuniter/relation/hookqueue_test.go View 1 chunk +0 lines, -298 lines 0 comments Download
D worker/apiuniter/relation/relation.go View 1 chunk +0 lines, -232 lines 0 comments Download
D worker/apiuniter/relation/relation_test.go View 1 chunk +0 lines, -351 lines 0 comments Download
D worker/apiuniter/relationer.go View 1 chunk +0 lines, -152 lines 0 comments Download
D worker/apiuniter/relationer_test.go View 1 chunk +0 lines, -470 lines 0 comments Download
D worker/apiuniter/state.go View 1 chunk +0 lines, -150 lines 0 comments Download
D worker/apiuniter/state_test.go View 1 chunk +0 lines, -170 lines 0 comments Download
D worker/apiuniter/tools.go View 1 chunk +0 lines, -31 lines 0 comments Download
D worker/apiuniter/tools_test.go View 1 chunk +0 lines, -69 lines 0 comments Download
D worker/apiuniter/uniter.go View 1 chunk +0 lines, -536 lines 0 comments Download
D worker/apiuniter/uniter_test.go View 1 chunk +0 lines, -1785 lines 0 comments Download
M worker/uniter/charm/charm.go View 5 chunks +21 lines, -12 lines 0 comments Download
M worker/uniter/charm/charm_test.go View 6 chunks +31 lines, -8 lines 0 comments Download
M worker/uniter/charm/deployer.go View 1 chunk +3 lines, -2 lines 0 comments Download
M worker/uniter/charm/deployer_test.go View 1 chunk +4 lines, -2 lines 0 comments Download
M worker/uniter/context.go View 9 chunks +37 lines, -16 lines 0 comments Download
M worker/uniter/context_test.go View 18 chunks +136 lines, -51 lines 0 comments Download
M worker/uniter/filter.go View 16 chunks +75 lines, -38 lines 0 comments Download
M worker/uniter/filter_test.go View 21 chunks +66 lines, -32 lines 0 comments Download
M worker/uniter/hook/hook.go View 1 chunk +1 line, -0 lines 0 comments Download
M worker/uniter/hook/hook_test.go View 1 chunk +3 lines, -1 line 0 comments Download
M worker/uniter/jujuc/config-get_test.go View 1 chunk +1 line, -0 lines 0 comments Download
M worker/uniter/jujuc/context.go View 2 chunks +6 lines, -5 lines 0 comments Download
M worker/uniter/jujuc/juju-log.go View 1 chunk +3 lines, -1 line 0 comments Download
M worker/uniter/jujuc/juju-log_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/jujuc/ports.go View 1 chunk +4 lines, -2 lines 0 comments Download
worker/uniter/jujuc/relation-get.go View 2 chunks +4 lines, -1 line 0 comments Download
worker/uniter/jujuc/relation-get_test.go View 2 chunks +5 lines, -3 lines 0 comments Download
worker/uniter/jujuc/relation-ids.go View 1 chunk +3 lines, -1 line 0 comments Download
worker/uniter/jujuc/relation-ids_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
worker/uniter/jujuc/relation-list.go View 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/jujuc/relation-list_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/jujuc/relation-set.go View 1 chunk +3 lines, -1 line 0 comments Download
M worker/uniter/jujuc/relation-set_test.go View 2 chunks +5 lines, -3 lines 0 comments Download
M worker/uniter/jujuc/unit-get.go View 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/jujuc/unit-get_test.go View 1 chunk +3 lines, -1 line 0 comments Download
M worker/uniter/jujuc/util_test.go View 4 chunks +10 lines, -7 lines 0 comments Download
M worker/uniter/modes.go View 7 chunks +26 lines, -27 lines 0 comments Download
M worker/uniter/relation/hookqueue.go View 1 chunk +4 lines, -2 lines 0 comments Download
M worker/uniter/relation/relation.go View 1 chunk +4 lines, -3 lines 0 comments Download
M worker/uniter/relation/relation_test.go View 1 chunk +5 lines, -3 lines 0 comments Download
M worker/uniter/relationer.go View 6 chunks +15 lines, -11 lines 0 comments Download
M worker/uniter/relationer_test.go View 10 chunks +63 lines, -19 lines 0 comments Download
M worker/uniter/state.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/state_test.go View 1 chunk +3 lines, -1 line 0 comments Download
M worker/uniter/tools.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/uniter.go View 14 chunks +48 lines, -47 lines 0 comments Download
M worker/uniter/uniter_test.go View 17 chunks +63 lines, -25 lines 0 comments Download

Messages

Total messages: 6
dimitern
Please take a look.
10 years, 7 months ago (2013-09-12 17:03:13 UTC) #1
dimitern
Please take a look.
10 years, 7 months ago (2013-09-12 17:06:19 UTC) #2
dimitern
Please take a look.
10 years, 7 months ago (2013-09-12 17:12:26 UTC) #3
rog
On 2013/09/12 17:12:26, dimitern wrote: > Please take a look. awesome stuff! LGTM assuming it ...
10 years, 7 months ago (2013-09-12 17:31:31 UTC) #4
dimitern
On 2013/09/12 17:31:31, rog wrote: > On 2013/09/12 17:12:26, dimitern wrote: > > Please take ...
10 years, 7 months ago (2013-09-13 09:16:43 UTC) #5
dimitern
10 years, 7 months ago (2013-09-13 09:26:53 UTC) #6
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b