Issue 13396045: code review 13396045: runtime: clean up map code. Remove hashmap.h.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13396045: code review 13396045: runtime: clean up map code. Remove hashmap.h. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by khr

Modified:
11 years, 8 months ago

Reviewers:
dvyukov

CC:
golang-dev, dvyukov

Visibility:
Public.

Description

runtime: clean up map code. Remove hashmap.h. Use cnew/cnewarray instead of mallocgc.

Patch Set 1 #

Patch Set 2 : diff -r 14cf1c9a2408 https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -15 lines)			Patch
R	src/pkg/runtime/hashmap.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	9 chunks	+9 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 8 months ago (2013-08-31 16:23:00 UTC) #1

khr

11 years, 8 months ago (2013-08-31 21:09:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2aef8fd83bbd ***

runtime: clean up map code.  Remove hashmap.h.
Use cnew/cnewarray instead of mallocgc.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/13396045

Expand All Messages | Collapse All Messages