Issue 13395046: code review 13395046: cmd/cgo: record full source path to input .go files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13395046: code review 13395046: cmd/cgo: record full source path to input .go files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/cgo: record full source path to input .go files Fixes issue 5122.

Patch Set 1 #

Patch Set 2 : diff -r 89dcc047a1ea https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7d17d5930d23 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 46750f5e7801 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	src/cmd/cgo/ast.go	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
	M	src/cmd/go/test.bash	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-09-09 16:53:52 UTC) #1

rsc

11 years, 7 months ago (2013-09-09 17:04:17 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ee979bde3449 ***

cmd/cgo: record full source path to input .go files

Fixes issue 5122.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13395046

Expand All Messages | Collapse All Messages