code review 13393045: regexp: fix a benchmark case

regexp: fix a benchmark case

I noticed that this one benchmark in particular was very
noisy.  Looking into it, I saw that the table was wrong
and inconsistent with the lines above and below.

[bradfitz, 2013-08-29 20:30:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[crawshaw1, 2013-08-29 20:54:02]

LGTM, based on the email. Chunk mismatch in codereview.

[bradfitz, 2013-08-29 20:54:53]

Operations are hanging and failing like crazy today.



On Thu, Aug 29, 2013 at 1:54 PM, <crawshaw@google.com> wrote:

> LGTM, based on the email. Chunk mismatch in codereview.
>
>
https://codereview.appspot.**com/13393045/<https://codereview.appspot.com/133...
>

[bradfitz, 2013-08-29 20:55:30]

*** Submitted as https://code.google.com/p/go/source/detail?r=842db87ecc8d ***

regexp: fix a benchmark case

I noticed that this one benchmark in particular was very
noisy.  Looking into it, I saw that the table was wrong
and inconsistent with the lines above and below.

R=golang-dev, crawshaw
CC=golang-dev
https://codereview.appspot.com/13393045

[dave_cheney.net, 2013-08-29 21:11:02]

LGTM.

On Fri, Aug 30, 2013 at 6:30 AM,  <bradfitz@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> regexp: fix a benchmark case
>
> I noticed that this one benchmark in particular was very
> noisy.  Looking into it, I saw that the table was wrong
> and inconsistent with the lines above and below.
>
> Please review this at https://codereview.appspot.com/13393045/
>
> Affected files:
>   src/pkg/regexp/exec_test.go
>
>
> Index: src/pkg/regexp/exec_test.go
> ===================================================================
> --- a/src/pkg/regexp/exec_test.go
> +++ b/src/pkg/regexp/exec_test.go
> @@ -689,7 +689,7 @@
>  func BenchmarkMatchEasy1_32K(b *testing.B)  { benchmark(b, easy1, 32<<10) }
>  func BenchmarkMatchEasy1_1M(b *testing.B)   { benchmark(b, easy1, 1<<20) }
>  func BenchmarkMatchEasy1_32M(b *testing.B)  { benchmark(b, easy1, 32<<20) }
> -func BenchmarkMatchMedium_32(b *testing.B)  { benchmark(b, medium, 1<<0) }
> +func BenchmarkMatchMedium_32(b *testing.B)  { benchmark(b, medium, 32<<0) }
>  func BenchmarkMatchMedium_1K(b *testing.B)  { benchmark(b, medium, 1<<10) }
>  func BenchmarkMatchMedium_32K(b *testing.B) { benchmark(b, medium, 32<<10)
> }
>  func BenchmarkMatchMedium_1M(b *testing.B)  { benchmark(b, medium, 1<<20) }
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.