Issue 13391049: code review 13391049: cmd/go: document that "main" is a reserved import path

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13391049: code review 13391049: cmd/go: document that "main" is a reserved import path (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:
dave

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

cmd/go: document that "main" is a reserved import path Fixes issue 6312.

Patch Set 2 : diff -r 94a8b036358b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 94a8b036358b https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
	M	src/cmd/go/doc.go	View	1	1 chunk	+10 lines, -5 lines	0 comments	Download
	M	src/cmd/go/help.go	View	1	1 chunk	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-09-16 09:55:23 UTC) #1

dave_cheney.net

LGTM. One suggestion. https://codereview.appspot.com/13391049/diff/1/src/cmd/go/doc.go File src/cmd/go/doc.go (right): https://codereview.appspot.com/13391049/diff/1/src/cmd/go/doc.go#newcode546 src/cmd/go/doc.go:546: the top-level package in a stand-alone ...

11 years, 7 months ago (2013-09-16 10:04:20 UTC) #2

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 7 months ago (2013-09-16 12:11:02 UTC) #3

dave_cheney.net

LGTM. Even better. On 16/09/2013, at 22:11, r@golang.org wrote: > Hello golang-dev@googlegroups.com, dave@cheney.net (cc: > ...

11 years, 7 months ago (2013-09-16 12:12:48 UTC) #4

11 years, 7 months ago (2013-09-16 12:53:47 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=45343b9c3db4 ***

cmd/go: document that "main" is a reserved import path
Fixes issue 6312.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/13391049

Expand All Messages | Collapse All Messages