Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1096)

Issue 13391047: testing/testingservice: support https

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jameinel
Modified:
10 years, 8 months ago
Reviewers:
mue, mp+183838
Visibility:
Public.

Description

testing/testingservice: support https I'm splitting up the work for handling bug #1202163 This updates the goose testing/httpsuite and the testservice infrastructure to allow an HTTPS endpoint. The direct differences are that you can instantiate the test suite with httpsuite.HTTPSuite{UseTLS:true}. That triggers the underlying standard library to use StartTLS instead of Start. The testservices were always reporting "http://" URLs, so this changes them to notice the Scheme of their base URL and continue using it. https://code.launchpad.net/~jameinel/goose/httpsuite-ssl/+merge/183838 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing/testingservice: support https #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/httpsuite/httpsuite.go View 1 chunk +6 lines, -1 line 0 comments Download
M testing/httpsuite/httpsuite_test.go View 3 chunks +29 lines, -0 lines 0 comments Download
M testservices/novaservice/service.go View 2 chunks +2 lines, -1 line 0 comments Download
M testservices/novaservice/service_http_test.go View 2 chunks +35 lines, -0 lines 0 comments Download
M testservices/service.go View 1 chunk +1 line, -0 lines 0 comments Download
M testservices/swiftservice/service.go View 2 chunks +2 lines, -1 line 0 comments Download
M testservices/swiftservice/service_http_test.go View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
10 years, 8 months ago (2013-09-04 10:28:48 UTC) #1
jameinel
Please take a look.
10 years, 8 months ago (2013-09-04 11:02:46 UTC) #2
mue
10 years, 8 months ago (2013-09-04 11:12:09 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b