Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(306)

Issue 13386047: code review 13386047: net/http: send correct time in Date header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dchest
Modified:
12 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev, dave_cheney.net, bradfitz
Visibility:
Public.

Description

net/http: send correct time in Date header. Date header indicated that it contained GMT time, however it actually sent local time. Fixed by converting time to UTC. Also fixes incorrect comment in appendTime(). Regression since CL 9432046.

Patch Set 1 #

Patch Set 2 : diff -r 954eee4cdc5e https://code.google.com/p/go #

Patch Set 3 : diff -r 954eee4cdc5e https://code.google.com/p/go #

Patch Set 4 : diff -r 954eee4cdc5e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/pkg/net/http/server.go View 1 1 chunk +2 lines, -1 line 0 comments Download
A src/pkg/net/http/server_test.go View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dchest
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-09-21 12:43:35 UTC) #1
dave_cheney.net
On 2013/09/21 12:43:35, dchest wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
12 years, 3 months ago (2013-09-21 12:46:59 UTC) #2
dchest
On 2013/09/21 12:46:59, dfc wrote: > On 2013/09/21 12:43:35, dchest wrote: > > Hello mailto:golang-dev@googlegroups.com ...
12 years, 3 months ago (2013-09-21 13:06:33 UTC) #3
dchest
On 2013/09/21 13:06:33, dchest wrote: > On 2013/09/21 12:46:59, dfc wrote: > > On 2013/09/21 ...
12 years, 3 months ago (2013-09-21 13:55:20 UTC) #4
bradfitz
LGTM Thanks! On Sat, Sep 21, 2013 at 5:43 AM, <dchest@gmail.com> wrote: > Reviewers: golang-dev1, ...
12 years, 3 months ago (2013-09-23 02:48:45 UTC) #5
bradfitz
Except this re-introduces the confusingly-similar server_test.go which we previously merged into serve_test.go. I've moved it ...
12 years, 3 months ago (2013-09-23 02:53:36 UTC) #6
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=a10b6786fa10 *** net/http: send correct time in Date header. Date header indicated ...
12 years, 3 months ago (2013-09-23 02:54:25 UTC) #7
dchest
12 years, 3 months ago (2013-09-23 06:17:43 UTC) #8
On 2013/09/23 02:53:36, bradfitz wrote:
> Except this re-introduces the confusingly-similar server_test.go which we
> previously merged into serve_test.go.
> I've moved it into serve_test.go and will submit.

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b