code review 13386047: net/http: send correct time in Date header.

net/http: send correct time in Date header.

Date header indicated that it contained GMT time,
however it actually sent local time. Fixed by
converting time to UTC.

Also fixes incorrect comment in appendTime().

Regression since CL 9432046.

[dchest, 2013-09-21 12:43:35]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-09-21 12:46:59]

On 2013/09/21 12:43:35, dchest wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Can you please include a test.

[dchest, 2013-09-21 13:06:33]

On 2013/09/21 12:46:59, dfc wrote:
> On 2013/09/21 12:43:35, dchest wrote:
> > Hello mailto:golang-dev@googlegroups.com (cc:
> mailto:golang-dev@googlegroups.com),
> > 
> > I'd like you to review this change to
> > https://code.google.com/p/go
> 
> Can you please include a test.

I started writing a test that checks that the difference between time.Now() and
what server returned is within 20 minutes, but it will only catch the error if
local time on test machine is not UTC.

Any suggestions on how to properly test this?

Thanks!

[dchest, 2013-09-21 13:55:20]

On 2013/09/21 13:06:33, dchest wrote:
> On 2013/09/21 12:46:59, dfc wrote:
> > On 2013/09/21 12:43:35, dchest wrote:
> > > Hello mailto:golang-dev@googlegroups.com (cc:
> > mailto:golang-dev@googlegroups.com),
> > > 
> > > I'd like you to review this change to
> > > https://code.google.com/p/go
> > 
> > Can you please include a test.
> 
> I started writing a test that checks that the difference between time.Now()
and
> what server returned is within 20 minutes, but it will only catch the error if
> local time on test machine is not UTC.
> 
> Any suggestions on how to properly test this?
> 
> Thanks!

Added a test for appendTime().

[bradfitz, 2013-09-23 02:48:45]

LGTM

Thanks!



On Sat, Sep 21, 2013 at 5:43 AM, <dchest@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net/http: send correct time in Date header.
>
> Date header indicated that it contained GMT time,
> however it actually sent local time. Fixed by
> converting time to UTC.
>
> Also fixes incorrect comment in appendTime().
>
> Regression since CL 9432046.
>
> Please review this at
https://codereview.appspot.**com/13386047/<https://codereview.appspot.com/133...
>
> Affected files (+2, -1 lines):
>   M src/pkg/net/http/server.go
>
>
> Index: src/pkg/net/http/server.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/server.go
> +++ b/src/pkg/net/http/server.go
> @@ -530,11 +530,12 @@
>  // It is like time.RFC1123 but hard codes GMT as the time zone.
>  const TimeFormat = "Mon, 02 Jan 2006 15:04:05 GMT"
>
> -// appendTime is a non-allocating version of []byte(time.Now().UTC().**
> Format(TimeFormat))
> +// appendTime is a non-allocating version of []byte(t.UTC().Format(**
> TimeFormat))
>  func appendTime(b []byte, t time.Time) []byte {
>         const days = "SunMonTueWedThuFriSat"
>         const months = "**JanFebMarAprMayJunJulAugSepOct**NovDec"
>
> +       t = t.UTC()
>         yy, mm, dd := t.Date()
>         hh, mn, ss := t.Clock()
>         day := days[3*t.Weekday():]
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[bradfitz, 2013-09-23 02:53:36]

Except this re-introduces the confusingly-similar server_test.go which we
previously merged into serve_test.go.

I've moved it into serve_test.go and will submit.



On Sun, Sep 22, 2013 at 7:48 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> LGTM
>
> Thanks!
>
>
>
> On Sat, Sep 21, 2013 at 5:43 AM, <dchest@gmail.com> wrote:
>
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> net/http: send correct time in Date header.
>>
>> Date header indicated that it contained GMT time,
>> however it actually sent local time. Fixed by
>> converting time to UTC.
>>
>> Also fixes incorrect comment in appendTime().
>>
>> Regression since CL 9432046.
>>
>> Please review this at
https://codereview.appspot.**com/13386047/<https://codereview.appspot.com/133...
>>
>> Affected files (+2, -1 lines):
>>   M src/pkg/net/http/server.go
>>
>>
>> Index: src/pkg/net/http/server.go
>> ==============================**==============================**=======
>> --- a/src/pkg/net/http/server.go
>> +++ b/src/pkg/net/http/server.go
>> @@ -530,11 +530,12 @@
>>  // It is like time.RFC1123 but hard codes GMT as the time zone.
>>  const TimeFormat = "Mon, 02 Jan 2006 15:04:05 GMT"
>>
>> -// appendTime is a non-allocating version of []byte(time.Now().UTC().**
>> Format(TimeFormat))
>> +// appendTime is a non-allocating version of []byte(t.UTC().Format(**
>> TimeFormat))
>>  func appendTime(b []byte, t time.Time) []byte {
>>         const days = "SunMonTueWedThuFriSat"
>>         const months = "**JanFebMarAprMayJunJulAugSepOct**NovDec"
>>
>> +       t = t.UTC()
>>         yy, mm, dd := t.Date()
>>         hh, mn, ss := t.Clock()
>>         day := days[3*t.Weekday():]
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
>> .
>> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
>> .
>>
>
>

[bradfitz, 2013-09-23 02:54:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=a10b6786fa10 ***

net/http: send correct time in Date header.

Date header indicated that it contained GMT time,
however it actually sent local time. Fixed by
converting time to UTC.

Also fixes incorrect comment in appendTime().

Regression since CL 9432046.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/13386047

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[dchest, 2013-09-23 06:17:43]

On 2013/09/23 02:53:36, bradfitz wrote:
> Except this re-introduces the confusingly-similar server_test.go which we
> previously merged into serve_test.go.
> I've moved it into serve_test.go and will submit.

Thanks!