Fix Chrome dev WebSocket sub-protocol error.

Fix Chrome dev WebSocket sub-protocol error.

Also updated the way we suggest to install
system dependencies.

Tests: `make unittest` from the branch root.

QA:

- Install the system dependencies by running the
  following command from the root of this branch:

  make sysdeps

- Bootstrap a juju-core environment:

  juju bootstrap --upload-tools

- From the root of this branch, deploy and expose
  the GUI running the following:

  make deploy

  The command above will exit when the GUI is ready.

- Switch to the GUI server, then wait a minute for the
  server to be ready:

  juju set juju-gui builtin-server=true

- With a development version of the Chrome browser
  (>=30), visit the GUI and check everything works well.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-ws-chrome/+merge/182913

(do not edit description out of merge proposal)

[frankban, 2013-08-29 13:53:57]

Please take a look.

[rharding, 2013-08-29 14:26:28]

LGTM, qa's ok now in chrome 31 and code looks cool. Just one comment on the doc
string there that it's not just that it needs it to be there, but that they need
to match.

https://codereview.appspot.com/13386043/diff/1/server/guiserver/handlers.py
File server/guiserver/handlers.py (right):

https://codereview.appspot.com/13386043/diff/1/server/guiserver/handlers.py#n...
server/guiserver/handlers.py:125: versions of the Chrome browser, which
disconnects if a sub-protocol
if the sub-protocol does not match the one sent by the client.

[frankban, 2013-08-29 14:39:48]

*** Submitted:

Fix Chrome dev WebSocket sub-protocol error.

Also updated the way we suggest to install
system dependencies.

Tests: `make unittest` from the branch root.

QA:

- Install the system dependencies by running the
  following command from the root of this branch:

  make sysdeps

- Bootstrap a juju-core environment:

  juju bootstrap --upload-tools

- From the root of this branch, deploy and expose
  the GUI running the following:

  make deploy

  The command above will exit when the GUI is ready.

- Switch to the GUI server, then wait a minute for the
  server to be ready:

  juju set juju-gui builtin-server=true

- With a development version of the Chrome browser
  (>=30), visit the GUI and check everything works well.

R=rharding
CC=
https://codereview.appspot.com/13386043

https://codereview.appspot.com/13386043/diff/1/server/guiserver/handlers.py
File server/guiserver/handlers.py (right):

https://codereview.appspot.com/13386043/diff/1/server/guiserver/handlers.py#n...
server/guiserver/handlers.py:125: versions of the Chrome browser, which
disconnects if a sub-protocol
On 2013/08/29 14:26:28, rharding wrote:
> if the sub-protocol does not match the one sent by the client. 

Done.

[frankban, 2013-08-29 14:42:56]

Thanks for the review Rick.