Add charmworld v3 API support.

Add charmworld v3 API support.

The v2 API was changed to be a subclass of v3 so that removing v2 when it is
retired will be easy.  There is a feature flag to enable the v3 API.

https://code.launchpad.net/~benji/juju-gui/charmworld-api-3/+merge/185325

(do not edit description out of merge proposal)

[benji, 2013-09-17 19:00:44]

Please take a look.

[gary.poster, 2013-09-17 19:17:36]

Hey.  I *think* this LGTM but would like some clarifications.  This would have
been a great branch for some pre-review comments, at least for me.

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js
File app/store/charm.js (left):

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#oldcode114
app/store/charm.js:114: result = result + '-1';
Don't we still want this for APIv2?

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#oldcode353
app/store/charm.js:353: @method filepath
why don't we need this now?  was it never used?  I don't see it in your APIv2
so...I'm confused.

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js
File app/store/charm.js (right):

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#newcode546
app/store/charm.js:546: * Charmworld API version 2 interface.
I'm assuming this has no changes?

[benji, 2013-09-17 20:37:50]

> This would have been a great branch for some pre-review comments, at
> least for me.

I intended to, but getting it into review took longer than I expected
and I had to step away so I decided getting it in review earlier was
more important that pre-review notes.  That may not have been the right
decision, especially on a branch with the subtlety of this one.

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js
File app/store/charm.js (left):

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#oldcode114
app/store/charm.js:114: result = result + '-1';
On 2013/09/17 19:17:36, gary.poster wrote:
> Don't we still want this for APIv2?

Yep.  The code was moved to the APIv2 class.  See line 618 of this file.

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#oldcode353
app/store/charm.js:353: @method filepath
On 2013/09/17 19:17:36, gary.poster wrote:
> why don't we need this now?  was it never used?  I don't see it in your APIv2
> so...I'm confused.

Right, it was never used.

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js
File app/store/charm.js (right):

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#newcode546
app/store/charm.js:546: * Charmworld API version 2 interface.
On 2013/09/17 19:17:36, gary.poster wrote:
> I'm assuming this has no changes?

Note that this inherits from APIv3 (like we do in charmworld).  Therefore the
only changes are removing things that are the same as APIv3 and moving in the
"add a fake revision number to charm ID" code that was discussed above.

I'm not certain this approach of having the older API inherit from the newer is
the best tradeoff, but it seems good enough to try.  For tests I took the
copy/paste approach because that seems like the right tradeoff.

[gary.poster, 2013-09-17 20:44:56]

Cool, thanks for the explanations.  It would have been nice to also see the new
tests, but anyway, LGTM, fly away. :-)

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js
File app/store/charm.js (right):

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#newcode549
app/store/charm.js:549: * @extends {Base}
My main comment, in line with your reply above, is that explaining the situation
would be nice.  Beyond that, Maybe @extends is supposed to say "{APIv3}"? 
<shrug>

[benji, 2013-09-17 20:51:37]

Thanks again.

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js
File app/store/charm.js (right):

https://codereview.appspot.com/13368056/diff/1/app/store/charm.js#newcode549
app/store/charm.js:549: * @extends {Base}
On 2013/09/17 20:44:56, gary.poster wrote:
> My main comment, in line with your reply above, is that explaining the
situation
> would be nice.  Beyond that, Maybe @extends is supposed to say "{APIv3}"? 
> <shrug>

I fixed the @extends and added some prose explaining the subclassing approach. 
Thanks.

[benji, 2013-09-17 20:59:52]

*** Submitted:

Add charmworld v3 API support.

The v2 API was changed to be a subclass of v3 so that removing v2 when it is
retired will be easy.  There is a feature flag to enable the v3 API.

R=gary.poster
CC=
https://codereview.appspot.com/13368056