hide and show save controls

hide and show save controls

In the inspector, controls to save values are hidden when there are no changes, and revealed when there are.  Changes can come from saving the form or from simply manually reverting values.

This also changes the "modified" asterisk to be removed when the user manually reverts values.

https://code.launchpad.net/~gary/juju-gui/peekabooInspectorSave/+merge/184688

(do not edit description out of merge proposal)

[gary.poster, 2013-09-09 21:15:17]

Please take a look.

[benjamin.saller, 2013-09-10 16:41:31]

Code LGTM
QA minors
  should the cancel button in the save dialog reset the form? is that not in
this branch?
  I like the green flash better than the icon fading I think but is that the
expected UX here?

As an aside an issue I thought was fixed shows in this branch where the scale up
ux didn't fit in the space provided. Is that a missing trunk merge or still
pending in a Huw branch?

In general the QA was good, if those are non issues feel free to land. You
mentioned a revision to this though, if you want another look let me know.

https://codereview.appspot.com/13368051/diff/1/test/test_inspector_constraint...
File test/test_inspector_constraints.js (right):

https://codereview.appspot.com/13368051/diff/1/test/test_inspector_constraint...
test/test_inspector_constraints.js:246: env.ws.msg(makeResponse(inspector.model,
false));
Nice test

[gary.poster, 2013-09-10 19:26:09]

*** Submitted:

hide and show save controls

In the inspector, controls to save values are hidden when there are no changes,
and revealed when there are.  Changes can come from saving the form or from
simply manually reverting values.

This also changes the "modified" asterisk to be removed when the user manually
reverts values.

R=benjamin.saller
CC=
https://codereview.appspot.com/13368051