Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(742)

Issue 13368049: Provide conflict UX for boolean config values

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rharding
Modified:
10 years, 7 months ago
Reviewers:
mp+183929, gary.poster
Visibility:
Public.

Description

Provide conflict UX for boolean config values - We can't use the valueChange event for checkboxes - Add support for get/set of the values on the checkbox. We want a bool, true/false, based on .get('checked') - The conflict UX needs to have a node added to supply the * backgroud image and removal when done - Add a test to walk through setting up the input, having it show as midified, conflicted, and resetting back to normal display. We need to get with UX and get a final design for a conflict. This is a temporary until we get that design. QA Instructions: - Deploy the mediawiki charm - Go to the config and check the 'debug' field. - It should show as modified. - Go to the console and enter var s = app.db.services.item(0); var c = s.set('config.debug', true); - Note it goes into conflict mode - Click the conflict icon, choose to clear it, and returns to state. https://code.launchpad.net/~rharding/juju-gui/conflict-checkbox/+merge/183929 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Provide conflict UX for boolean config values #

Patch Set 3 : Provide conflict UX for boolean config values #

Total comments: 1

Patch Set 4 : Provide conflict UX for boolean config values #

Patch Set 5 : Provide conflict UX for boolean config values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -23 lines) Patch
[revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
app/templates/conflict-ux.partial View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
app/templates/service-configuration.partial View 1 2 3 4 chunks +4 lines, -2 lines 0 comments Download
app/views/databinding.js View 2 chunks +12 lines, -2 lines 0 comments Download
app/views/inspector.js View 1 2 3 4 3 chunks +127 lines, -11 lines 0 comments Download
lib/views/juju-inspector.less View 1 2 3 4 3 chunks +40 lines, -1 line 0 comments Download
test/test_conflict_ux.js View 4 chunks +75 lines, -4 lines 0 comments Download

Messages

Total messages: 7
rharding
Please take a look.
10 years, 7 months ago (2013-09-04 16:51:33 UTC) #1
rharding
Please take a look.
10 years, 7 months ago (2013-09-05 11:24:19 UTC) #2
rharding
Please take a look.
10 years, 7 months ago (2013-09-05 11:43:42 UTC) #3
rharding
Please take a look.
10 years, 7 months ago (2013-09-05 13:19:12 UTC) #4
gary.poster
LGTM without qa https://codereview.appspot.com/13368049/diff/8001/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/13368049/diff/8001/app/views/inspector.js#newcode1067 app/views/inspector.js:1067: '_clearModified': function(node) { I kinda wish ...
10 years, 7 months ago (2013-09-05 13:57:07 UTC) #5
jeff.pihach
qa ok
10 years, 7 months ago (2013-09-05 16:07:59 UTC) #6
rharding
10 years, 7 months ago (2013-09-05 16:14:33 UTC) #7
*** Submitted:

Provide conflict UX for boolean config values

- We can't use the valueChange event for checkboxes
- Add support for get/set of the values on the checkbox. We want a bool,
	true/false, based on .get('checked')
- The conflict UX needs to have a node added to supply the * backgroud image
and removal when done
- Add a test to walk through setting up the input, having it show as midified,
	conflicted, and resetting back to normal display.

We need to get with UX and get a final design for a conflict. This is a
temporary until we get that design.

QA Instructions:

- Deploy the mediawiki charm
- Go to the config and check the 'debug' field.
- It should show as modified.
- Go to the console and enter
    var s = app.db.services.item(0); var c = s.set('config.debug', true);
- Note it goes into conflict mode
- Click the conflict icon, choose to clear it, and returns to state.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/13368049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b