Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 13368046: code review 13368046: runtime, syscall: update for openbsd system ABI break (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by jsing
Modified:
1 year, 1 month ago
Reviewers:
mikio
CC:
golang-codereviews, mikio
Visibility:
Public.

Description

runtime, syscall: update for openbsd system ABI break Update Go so that it continues to work past the OpenBSD system ABI break, with 64-bit time_t: http://www.openbsd.org/faq/current.html#20130813 Note: this makes OpenBSD 5.5 (currently 5.4-current) the minimum supported release for Go. Fixes issue 7049.

Patch Set 1 : diff -r b3caf13d930b https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r b3caf13d930b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5330d59be152 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 21fb28e644a1 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 21fb28e644a1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -246 lines) Patch
M src/pkg/runtime/defs_openbsd_386.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/runtime/defs_openbsd_amd64.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/pkg/runtime/sys_openbsd_386.s View 5 chunks +29 lines, -25 lines 0 comments Download
M src/pkg/runtime/sys_openbsd_amd64.s View 7 chunks +9 lines, -9 lines 0 comments Download
M src/pkg/syscall/syscall_openbsd.go View 2 chunks +5 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_openbsd_386.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_openbsd_amd64.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/syscall/zerrors_openbsd_386.go View 1 23 chunks +23 lines, -18 lines 0 comments Download
M src/pkg/syscall/zerrors_openbsd_amd64.go View 22 chunks +19 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_386.go View 2 chunks +17 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_amd64.go View 2 chunks +17 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsysctl_openbsd.go View 5 chunks +2 lines, -26 lines 0 comments Download
M src/pkg/syscall/zsysnum_openbsd_386.go View 10 chunks +30 lines, -27 lines 0 comments Download
M src/pkg/syscall/zsysnum_openbsd_amd64.go View 10 chunks +30 lines, -27 lines 0 comments Download
M src/pkg/syscall/ztypes_openbsd_386.go View 1 8 chunks +23 lines, -22 lines 0 comments Download
M src/pkg/syscall/ztypes_openbsd_amd64.go View 9 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 3
jsing
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 2 months ago (2014-01-02 04:00:17 UTC) #1
mikio
LGTM
1 year, 2 months ago (2014-01-02 05:17:16 UTC) #2
jsing
1 year, 1 month ago (2014-01-11 08:00:41 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=5626eb9eda64 ***

runtime, syscall: update for openbsd system ABI break

Update Go so that it continues to work past the OpenBSD system ABI
break, with 64-bit time_t:

  http://www.openbsd.org/faq/current.html#20130813

Note: this makes OpenBSD 5.5 (currently 5.4-current) the minimum
supported release for Go.

Fixes issue 7049.

R=golang-codereviews, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/13368046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1437:571d95b2634e