code review 133660043: runtime: get rid of other Go->C calls in test exports.

runtime: get rid of other Go->C calls in test exports.

testSchedLocal* tests need to malloc now because their
stack frames are too big to fit on the G0 stack.

[khr, 2014-09-05 23:02:37]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[iant, 2014-09-05 23:43:16]

LGTM

https://codereview.appspot.com/133660043/diff/80001/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

https://codereview.appspot.com/133660043/diff/80001/src/pkg/runtime/proc.c#ne...
src/pkg/runtime/proc.c:3554: runtime·memclr((byte*)p, sizeof(*p));
The value comes back zeroed anyhow; why memclr?

Same question for testSchedLocalQueueSteal.

[khr1, 2014-09-06 17:02:25]

On Fri, Sep 5, 2014 at 4:43 PM, <iant@golang.org> wrote:

> LGTM
>
>
> https://codereview.appspot.com/133660043/diff/80001/src/pkg/runtime/proc.c
> File src/pkg/runtime/proc.c (right):
>
> https://codereview.appspot.com/133660043/diff/80001/src/
> pkg/runtime/proc.c#newcode3554
> src/pkg/runtime/proc.c:3554: runtime·memclr((byte*)p, sizeof(*p));
> The value comes back zeroed anyhow; why memclr?
>
>
Right, just a holdover from the old code.  Will delete.


> Same question for testSchedLocalQueueSteal.
>
> https://codereview.appspot.com/133660043/
>

[khr, 2014-09-06 17:07:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=641fe1f8f29d ***

runtime: get rid of other Go->C calls in test exports.

testSchedLocal* tests need to malloc now because their
stack frames are too big to fit on the G0 stack.

LGTM=iant
R=golang-codereviews, iant, khr
CC=golang-codereviews
https://codereview.appspot.com/133660043