Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3296)

Issue 13360044: client/Client: Add API for non-validating SSL

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jameinel
Modified:
10 years, 8 months ago
Reviewers:
mue, mp+183847
Visibility:
Public.

Description

client/Client: Add API for non-validating SSL This is the final goose step for supporting self-signed certificates for the Openstack Provider (bug #1202163). It adds an API (like was done for the http.Client object) named goose/client.NewNonValidatingClient. It then changes around the code a bit so that we grab the HTTP connection early, and then use it in sendRequest. We also had to change the Authenticators so that we can pass in the http.Client object. Legacy was the only one that used a raw net/http.Client and it should be pretty straightforward how it was changed. Also, to pass in the Client object, I added a new function identity.NewAuthenticator(AuthMode, http.Client). This lets us set private attributes, and allows us to not have external switch statements about how to treat the various auth modes. https://code.launchpad.net/~jameinel/goose/ssl-hostname-verify-false-1202163/+merge/183847 Requires: https://code.launchpad.net/~jameinel/goose/httpclient-ssl/+merge/183844 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -20 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M client/client.go View 2 chunks +18 lines, -18 lines 0 comments Download
M client/local_test.go View 3 chunks +67 lines, -0 lines 0 comments Download
M identity/identity.go View 2 chunks +21 lines, -0 lines 0 comments Download
M identity/identity_test.go View 3 chunks +54 lines, -0 lines 0 comments Download
M identity/legacy.go View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years, 8 months ago (2013-09-04 10:52:38 UTC) #1
mue
10 years, 8 months ago (2013-09-04 11:05:45 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b