Issue 13359046: code review 13359046: runtime/race: update runtime to r191161.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13359046: code review 13359046: runtime/race: update runtime to r191161. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by dvyukov

Modified:
11 years, 11 months ago

Reviewers:
r, brainman

CC:
golang-dev, dave_cheney.net, brainman, r

Visibility:
Public.

Description

runtime/race: update runtime to r191161. Fixes issue 6305.

Patch Set 1 #

Patch Set 2 : diff -r 9598aaf0b7d5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 9598aaf0b7d5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9598aaf0b7d5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 9567c5da6e25 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
M	src/pkg/runtime/race/README	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/race/race_darwin_amd64.syso	View	1	Binary file		0 comments	Download
M	src/pkg/runtime/race/race_linux_amd64.syso	View	1	Binary file		0 comments	Download
M	src/pkg/runtime/race/race_windows_amd64.syso	View	1	Binary file		0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 11 months ago (2013-09-22 03:22:22 UTC) #1

dave_cheney.net

On 2013/09/22 03:22:22, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

11 years, 11 months ago (2013-09-22 04:45:35 UTC) #2

minux1

r +alex.brainman windows/amd64 users, please help this change which i suppose is mainly what the ...

11 years, 11 months ago (2013-09-22 05:10:00 UTC) #3

brainman

I will test it tomorrow. I don't have appropriate computer now. Alex

11 years, 11 months ago (2013-09-22 07:52:59 UTC) #5

dvyukov

11 years, 11 months ago (2013-09-22 18:24:51 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=00ff0c821b3f ***

runtime/race: update runtime to r191161.
Fixes issue 6305.

R=golang-dev, dave, alex.brainman, r
CC=golang-dev
https://codereview.appspot.com/13359046

Expand All Messages | Collapse All Messages