Enable Landscape links.

Enable Landscape links.

Add support for Landscape external links
in the inspector unit listing and unit detail
views.

Move the getLandscapeURL function from the
landscape view to the utils module, so that
the URL can be retrieved without instantiating
a view.

Include the viewlet manager attributes in the
generated viewlets, so that binding objects can
have access to the objects included in the 
manager, e.g. the db instance.

Split the unit detail viewlet rendering logic
into two methods (render and getContext) in order
to make it easier to test the viewlet.

Include some docstring/CSS clean up.

https://code.launchpad.net/~frankban/juju-gui/landscape-improvements/+merge/184288

(do not edit description out of merge proposal)

[frankban, 2013-09-06 12:35:12]

Please take a look.

[matthew.scott, 2013-09-06 12:56:39]

LGTM - IEQA okay.  Thanks!

[bac, 2013-09-06 13:56:01]

LGTM.  No QA.

https://codereview.appspot.com/13358045/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/13358045/diff/1/app/views/utils.js#newcode1243
app/views/utils.js:1243: url += utils.ensureTrailingSlash(annotation);
This line, and its friend below, can be moved outside the conditional so it only
appears once.

[frankban, 2013-09-06 14:08:11]

*** Submitted:

Enable Landscape links.

Add support for Landscape external links
in the inspector unit listing and unit detail
views.

Move the getLandscapeURL function from the
landscape view to the utils module, so that
the URL can be retrieved without instantiating
a view.

Include the viewlet manager attributes in the
generated viewlets, so that binding objects can
have access to the objects included in the 
manager, e.g. the db instance.

Split the unit detail viewlet rendering logic
into two methods (render and getContext) in order
to make it easier to test the viewlet.

Include some docstring/CSS clean up.

R=matthew.scott, bac
CC=
https://codereview.appspot.com/13358045

https://codereview.appspot.com/13358045/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/13358045/diff/1/app/views/utils.js#newcode1243
app/views/utils.js:1243: url += utils.ensureTrailingSlash(annotation);
On 2013/09/06 13:56:02, bac wrote:
> This line, and its friend below, can be moved outside the conditional so it
only
> appears once.

I am not sure about that, since the conditional does not resolve all the cases,
and the current implementation reflects what previously present in the landscape
view.

[frankban, 2013-09-06 14:09:46]

Thank you both for the reviews!