Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(503)

Issue 133580043: code review 133580043: go/parser: initialize file set even in only some tests ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by gri
Modified:
10 years, 7 months ago
Reviewers:
adonovan
CC:
adonovan, golang-codereviews
Visibility:
Public.

Description

go/parser: initialize file set even in only some tests are run Without this fix, some tests crashed (e.g. go test -run Invalid).

Patch Set 1 #

Patch Set 2 : diff -r 7def488f5b8eb4a28e273ceeb339eb966ad99600 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/pkg/go/parser/error_test.go View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
gri
Hello adonovan (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2014-09-04 17:33:36 UTC) #1
adonovan
On 2014/09/04 17:33:36, gri wrote: > Hello adonovan (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
10 years, 7 months ago (2014-09-04 17:34:21 UTC) #2
gri
10 years, 7 months ago (2014-09-04 17:43:07 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=0c34407aaa88 ***

go/parser: initialize file set even in only some tests are run

Without this fix, some tests crashed (e.g. go test -run Invalid).

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/133580043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b