Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 13356047: code review 13356047: go.tools/godoc: some content re-organization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by adg
Modified:
6 years, 2 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

go.tools/godoc: some content re-organization Remove References section heading. Add redirects from old paths to new content. Add a link to the SubRepositories wiki page from package list. Add styles for "pop-out" link.

Patch Set 1 #

Patch Set 2 : diff -r be045f224499 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r be045f224499 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r be045f224499 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r beeebf8de27f https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 6 : diff -r beeebf8de27f https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M cmd/godoc/handlers.go View 1 2 3 1 chunk +32 lines, -13 lines 0 comments Download
M godoc/static/godoc.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M godoc/static/package.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M godoc/static/static.go View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download
M godoc/static/style.css View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4
adg
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
6 years, 2 months ago (2013-09-16 05:09:11 UTC) #1
r
LGTM https://codereview.appspot.com/13356047/diff/11001/cmd/godoc/handlers.go File cmd/godoc/handlers.go (right): https://codereview.appspot.com/13356047/diff/11001/cmd/godoc/handlers.go#newcode137 cmd/godoc/handlers.go:137: "/ref/": "/doc/#references", why is this one alone here ...
6 years, 2 months ago (2013-09-16 05:20:00 UTC) #2
adg
https://codereview.appspot.com/13356047/diff/11001/cmd/godoc/handlers.go File cmd/godoc/handlers.go (right): https://codereview.appspot.com/13356047/diff/11001/cmd/godoc/handlers.go#newcode137 cmd/godoc/handlers.go:137: "/ref/": "/doc/#references", On 2013/09/16 05:20:00, r wrote: > why ...
6 years, 2 months ago (2013-09-16 05:22:23 UTC) #3
adg
6 years, 2 months ago (2013-09-16 05:46:49 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=2ef4443d05a6&repo=tools ***

go.tools/godoc: some content re-organization

Remove References section heading.
Add redirects from old paths to new content.
Add a link to the SubRepositories wiki page from package list.
Add styles for "pop-out" link.

R=r
CC=golang-dev
https://codereview.appspot.com/13356047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b