Issue 13354043: code review 13354043: go.tools/cmd/ssadump: move ssa/ssadump.go command to it...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13354043: code review 13354043: go.tools/cmd/ssadump: move ssa/ssadump.go command to it... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by adonovan

Modified:
12 years, 2 months ago

Reviewers:
crawshaw1

CC:
crawshaw1, golang-dev

Visibility:
Public.

Description

go.tools/cmd/ssadump: move ssa/ssadump.go command to its own package. (Its former location was based on a misunderstanding of 'go build'.) Also: set GOMAXPROCS to NumCPU by default.

Patch Set 1 #

Patch Set 2 : diff -r 28b59754195f https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 28b59754195f https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 28b59754195f https://code.google.com/p/go.tools #

Patch Set 5 : diff -r dee23b06c75c https://code.google.com/p/go.tools #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	cmd/ssadump/main.go	View	1	2 chunks	+14 lines, -4 lines	0 comments	Download
	M	ssa/interp/interp_test.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 2 months ago (2013-08-28 18:08:50 UTC) #1

adonovan

*** Submitted as https://code.google.com/p/go/source/detail?r=850bd7b6f2ee&repo=tools *** go.tools/cmd/ssadump: move ssa/ssadump.go command to its own package. (Its former ...

12 years, 2 months ago (2013-08-30 01:34:38 UTC) #3

Message was sent while issue was closed.

*** Abandoned ***

Expand All Messages | Collapse All Messages