Issue 13352057: code review 13352057: fossil: required p9p changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13352057: code review 13352057: fossil: required p9p changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by 0intro

Modified:
11 years, 3 months ago

Reviewers:
rsc

CC:
rsc

Visibility:
Public.

Description

fossil: required p9p changes

Patch Set 1 #

Patch Set 2 : diff -r 35cedd39c9ae https://code.google.com/p/plan9port/ #

Patch Set 3 : diff -r 35cedd39c9ae https://code.google.com/p/plan9port/ #

Patch Set 4 : diff -r 35cedd39c9ae https://code.google.com/p/plan9port/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -67 lines)			Patch
M	src/cmd/fossil/9p.c	View	1	5 chunks	+13 lines, -0 lines	0 comments	Download
M	src/cmd/fossil/9proc.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/fossil/9srv.c	View	1	4 chunks	+12 lines, -0 lines	0 comments	Download
M	src/cmd/fossil/9user.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/fossil/Ccmd.c	View	1	10 chunks	+29 lines, -13 lines	0 comments	Download
M	src/cmd/fossil/Ccons.c	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	src/cmd/fossil/check.c	View	1	1 chunk	+16 lines, -4 lines	0 comments	Download
M	src/cmd/fossil/dat.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/fossil/disk.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/fossil/flchk.c	View	1	1 chunk	+11 lines, -4 lines	0 comments	Download
M	src/cmd/fossil/fossil.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/fossil/mkfile	View	1	4 chunks	+15 lines, -9 lines	0 comments	Download
M	src/cmd/fossil/nobwatch.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/fossil/stdinc.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/cmd/fossil/view.c	View	1	9 chunks	+31 lines, -29 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port/

11 years, 3 months ago (2013-09-23 21:26:36 UTC) #1

0intro

I've to submit the patch to make the p9p build working again.

11 years, 3 months ago (2013-09-26 18:12:11 UTC) #4

0intro

*** Submitted as https://code.google.com/p/plan9port/source/detail?r=7d8e2ec7fbd5 *** fossil: required p9p changes R=rsc https://codereview.appspot.com/13352057

11 years, 3 months ago (2013-09-26 18:13:04 UTC) #5

LGTM

Expand All Messages | Collapse All Messages