Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(593)

Issue 13352043: code review 13352043: go.tools/oracle: change -ptalog default to "". (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by adonovan
Modified:
8 years, 10 months ago
Reviewers:
crawshaw1
CC:
crawshaw1, golang-dev
Visibility:
Public.

Description

go.tools/oracle: change -ptalog default to "". Also: add a TODO.

Patch Set 1 #

Patch Set 2 : diff -r e0e6ef889f55 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r e0e6ef889f55 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r e0e6ef889f55 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r a1b18b4f7e37 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cmd/oracle/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/oracle/oracle.el View 1 2 chunks +1 line, -1 line 0 comments Download
M cmd/oracle/oracle.vim View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
adonovan
Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
8 years, 10 months ago (2013-08-28 17:26:53 UTC) #1
crawshaw1
LGTM
8 years, 10 months ago (2013-08-28 18:47:29 UTC) #2
adonovan
*** Submitted as https://code.google.com/p/go/source/detail?r=dee23b06c75c&repo=tools *** go.tools/oracle: change -ptalog default to "". Also: add a TODO. ...
8 years, 10 months ago (2013-08-30 01:32:52 UTC) #3
adonovan
8 years, 10 months ago (2013-08-30 01:41:18 UTC) #4
Message was sent while issue was closed.
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b