Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(767)

Issue 13350043: Sort deltas from juju core

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by matthew.scott
Modified:
10 years, 8 months ago
Reviewers:
benjamin.saller, mp+182697, rharding
Visibility:
Public.

Description

Sort deltas from juju core Deltas need to be processed in a certain order (service - relation - unit - machine - annotation); sort them before processing a delta. https://code.launchpad.net/~makyo/juju-gui/sort-deltas/+merge/182697 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Sort deltas from juju core #

Patch Set 3 : Sort deltas from juju core #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 1 chunk +21 lines, -2 lines 0 comments Download
M test/test_env_go.js View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6
matthew.scott
Please take a look.
10 years, 8 months ago (2013-08-28 16:37:12 UTC) #1
rharding
LGTM with test note https://codereview.appspot.com/13350043/diff/1/test/test_env_go.js File test/test_env_go.js (right): https://codereview.appspot.com/13350043/diff/1/test/test_env_go.js#newcode1251 test/test_env_go.js:1251: ['service', 'deploy', {}] I'd just ...
10 years, 8 months ago (2013-08-28 17:01:28 UTC) #2
benjamin.saller
LGTM, thanks Thanks for talking this through on IRC as well
10 years, 8 months ago (2013-08-28 17:10:28 UTC) #3
matthew.scott
Please take a look.
10 years, 8 months ago (2013-08-28 17:18:24 UTC) #4
benjamin.saller
still LGTM. might be that if you're really defensive you'd check that a[0] and b[0] ...
10 years, 8 months ago (2013-08-28 17:24:03 UTC) #5
matthew.scott
10 years, 8 months ago (2013-08-28 17:34:15 UTC) #6
*** Submitted:

Sort deltas from juju core

Deltas need to be processed in a certain order (service - relation - unit -
machine - annotation); sort them before processing a delta.

R=rharding, benjamin.saller
CC=
https://codereview.appspot.com/13350043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b