code review 133500043: undo CL 140110043 / 17b5fc2aa130

undo CL 140110043 / 17b5fc2aa130

I have found better approach, then longer wait.
See CL 134360043 for details.

««« original CL description
runtime/pprof: adjust cpuHogger so that tests pass on windows builders

LGTM=rsc
R=dvyukov, rsc
CC=golang-codereviews
https://codereview.appspot.com/140110043

Committer: Russ Cox <rsc@golang.org>
»»»

[brainman, 2014-09-03 02:45:36]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2014-09-03 02:57:10]

LGTM.

On Wed, Sep 3, 2014 at 12:45 PM,  <alex.brainman@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> undo CL 140110043 / 17b5fc2aa130
>
> I have found better approach, then longer wait.
> See CL 134360043 for details.
>
> ««« original CL description
> runtime/pprof: adjust cpuHogger so that tests pass on windows builders
>
> LGTM=rsc
> R=dvyukov, rsc
> CC=golang-codereviews
> https://codereview.appspot.com/140110043
>
> Committer: Russ Cox <rsc@golang.org>
> »»»
>
> Please review this at https://codereview.appspot.com/133500043/
>
> Affected files (+4, -4 lines):
>   M src/pkg/runtime/pprof/pprof_test.go
>
>
> Index: src/pkg/runtime/pprof/pprof_test.go
> ===================================================================
> --- a/src/pkg/runtime/pprof/pprof_test.go
> +++ b/src/pkg/runtime/pprof/pprof_test.go
> @@ -23,12 +23,12 @@
>
>  func cpuHogger(f func()) {
>         // We only need to get one 100 Hz clock tick, so we've got
> -       // a 100x safety buffer.
> -       // But do at least 2000 iterations (which should take about 400ms),
> +       // a 25x safety buffer.
> +       // But do at least 500 iterations (which should take about 100ms),
>         // otherwise TestCPUProfileMultithreaded can fail if only one
> -       // thread is scheduled during the 1 second period.
> +       // thread is scheduled during the 250ms period.
>         t0 := time.Now()
> -       for i := 0; i < 2000 || time.Since(t0) < time.Second; i++ {
> +       for i := 0; i < 500 || time.Since(t0) < 250*time.Millisecond; i++ {
>                 f()
>         }
>  }
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[brainman, 2014-09-03 02:58:17]

On 2014/09/03 02:57:10, dfc wrote:
> LGTM.
> 

Thank you, but I will wait for CL 134360043 to be submitted first. Otherwise
this will break builders again.

Alex

[dvyukov, 2014-09-03 03:36:01]

Wait, freebsd-race builder was flaky as well. Looking at the windows bot, it
seems that the initial 250ms estimation was wrong, builders were always running
this test for longer. Maybe bump the duration to 500ms and see whether it will
cause flakes or not.

[brainman, 2014-09-03 04:12:58]

On 2014/09/03 03:36:01, dvyukov wrote:
> ... Maybe bump the duration to 500ms and see whether it will
> cause flakes or not.

I would like to leave this CL as is. It is an undo of previous CL. You can
change what you like later. Are you OK with that?

Alex

[brainman, 2014-09-09 03:11:39]

Hello golang-codereviews@googlegroups.com, dave@cheney.net, dvyukov@google.com
(cc: golang-codereviews@googlegroups.com),

Please take another look.

[brainman, 2014-09-09 03:12:00]

I will submit this later today, unless I head objections.

Alex

[brainman, 2014-09-09 06:05:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=6402b5535fa8 ***

undo CL 140110043 / 17b5fc2aa130

I have found better approach, then longer wait.
See CL 134360043 for details.

««« original CL description
runtime/pprof: adjust cpuHogger so that tests pass on windows builders

LGTM=rsc
R=dvyukov, rsc
CC=golang-codereviews
https://codereview.appspot.com/140110043

Committer: Russ Cox <rsc@golang.org>
»»»

LGTM=dave
R=golang-codereviews, dave, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/133500043