Issue 13349043: charm: reverted empty string branch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13349043: charm: reverted empty string branch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by mue

Modified:
10 years, 8 months ago

Reviewers:
mp+182693, jameinel

Visibility:
Public.

Description

charm: reverted empty string branch Reverted the branch allowing empty string values in charm configurations due incompatability with the API. https://code.launchpad.net/~themue/juju-core/041-revert-empty-strings-in-charm-config/+merge/182693 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -16 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/config.go	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	charm/config_test.go	View	4 chunks	+14 lines, -13 lines	0 comments	Download
M	state/apiserver/client/get_test.go	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	state/service_test.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jameinel

10 years, 8 months ago (2013-08-28 16:31:08 UTC) #2

Given it is just reverting a patch you and William agreed should be pulled out,
LGTM

Expand All Messages | Collapse All Messages