Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1677)

Issue 13348049: environs/testing: move FakeHome etc from testing

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rog
Modified:
10 years, 8 months ago
Reviewers:
mp+183243
Visibility:
Public.

Description

environs/testing: move FakeHome etc from testing All the fake home stuff is about setting up environments. Given that environments/testing exists, it makes sense for it to live there. There's one unfortunate wrinkle, which is that one state internal test suite now depends on environs/testing, which depends on environs, which depends on state. The dependency is resolved with a moderately sleazy variable initialisation. I still think the move is worth it, despite the above. https://code.launchpad.net/~rogpeppe/juju-core/383-move-fakehome-etc/+merge/183243 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -205 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/environmentcommand_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/bootstrap_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M cmd/juju/cmd_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/debuglog_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/helptool_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M cmd/juju/init_test.go View 7 chunks +9 lines, -8 lines 0 comments Download
M cmd/juju/main_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M cmd/juju/plugin_test.go View 5 chunks +9 lines, -8 lines 0 comments Download
M cmd/juju/publish_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/switch_test.go View 8 chunks +15 lines, -14 lines 0 comments Download
M cmd/juju/synctools_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata_test.go View 10 chunks +10 lines, -9 lines 0 comments Download
M cmd/plugins/juju-metadata/metadataplugin_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M cmd/plugins/juju-metadata/validateimagemetadata_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M cmd/plugins/juju-metadata/validatetoolsmetadata_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M container/lxc/lxc_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/bootstrap/bootstrap_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
D environs/cert_internal_test.go View 1 chunk +0 lines, -50 lines 0 comments Download
M environs/cert_test.go View 6 chunks +43 lines, -8 lines 0 comments Download
M environs/config/config_test.go View 9 chunks +11 lines, -10 lines 0 comments Download
M environs/config_test.go View 9 chunks +10 lines, -9 lines 0 comments Download
M environs/emptystorage_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M environs/export_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/imagemetadata/urls_test.go View 1 chunk +3 lines, -2 lines 0 comments Download
M environs/imagemetadata/validation_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M environs/manual/detection_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/open_test.go View 6 chunks +7 lines, -6 lines 0 comments Download
M environs/sync/sync_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/testing/environ.go View 2 chunks +8 lines, -5 lines 0 comments Download
M environs/testing/environ_test.go View 1 chunk +6 lines, -1 line 0 comments Download
M environs/tools/urls_test.go View 1 chunk +1 line, -9 lines 0 comments Download
M environs/tools/validation_test.go View 2 chunks +4 lines, -3 lines 0 comments Download
M juju/apiconn_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M juju/conn_test.go View 3 chunks +5 lines, -4 lines 0 comments Download
M provider/local/environprovider_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M provider/openstack/config_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M state/conn_test.go View 2 chunks +5 lines, -1 line 0 comments Download
M state/environ_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/export_test.go View 1 chunk +2 lines, -6 lines 0 comments Download
M state/initialize_test.go View 5 chunks +5 lines, -4 lines 0 comments Download
M state/megawatcher_internal_test.go View 3 chunks +8 lines, -1 line 0 comments Download
M worker/provisioner/lxc-broker_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M worker/uniter/charm/git_test.go View 2 chunks +2 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b