Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3082)

Issue 13347043: Adjust z-index to keep fullscreen above inspector

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rharding
Modified:
10 years, 8 months ago
Reviewers:
benjamin.saller, mp+182687, gary.poster
Visibility:
Public.

Description

Adjust z-index to keep fullscreen above inspector - The inspector is set to jump z-indexes up to 999 which causes it to overlay the browser views all set to 1/2. - I investigated the current 'stack' and most of the indexes are set to <20 and > 1000, so adjusted the inspectors to sit in the middle around 500, made the browser views just over that at 600. - Verified all notifications, overlays, etc are > 600 (they're at 1000 and higher) So general rule of thumb is basic things < 100, floating things at 500+, overlay things > 1000. Audit from grepping for z-indexes: lib/views/browser/browser-icon.less: z-index: 10; lib/views/browser/bws-searchbox.less: z-index: 15; lib/views/browser/charm-full.less: z-index: 10; lib/views/browser/charm-token.less: z-index: 10; lib/views/browser/main.less: z-index: 1; lib/views/browser/main.less: z-index: 2; lib/views/browser/overlay-indicator.less: z-index: 999; lib/views/cookies.less: z-index: 100; lib/views/juju-inspector.less: z-index: 1; lib/views/juju-inspector.less: z-index: 0; lib/views/juju-inspector.less: z-index: 2; lib/views/stylesheet.less: z-index: 10; lib/views/stylesheet.less: z-index: 9999; lib/views/stylesheet.less: z-index: 10; lib/views/stylesheet.less: z-index: 100; /** This is the inspector stuff here v **/ lib/views/stylesheet.less: z-index: 999; lib/views/stylesheet.less: z-index: 0; lib/views/stylesheet.less: z-index: 2; lib/views/stylesheet.less: z-index: 2; lib/views/stylesheet.less: z-index: 10000; lib/views/stylesheet.less: z-index: 10001; https://code.launchpad.net/~rharding/juju-gui/inspector-zindex-1216039/+merge/182687 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adjust z-index to keep fullscreen above inspector #

Patch Set 3 : Adjust z-index to keep fullscreen above inspector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/browser/main.less View 2 chunks +1 line, -2 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 5
rharding
Please take a look.
10 years, 8 months ago (2013-08-28 15:49:15 UTC) #1
gary.poster
This is your *non* qa LGTM :-). As discussed on IRC, please add a note ...
10 years, 8 months ago (2013-08-28 15:56:36 UTC) #2
rharding
Please take a look.
10 years, 8 months ago (2013-08-28 16:06:37 UTC) #3
benjamin.saller
LGTM, did brief QA, worked as expected for me. Thanks
10 years, 8 months ago (2013-08-28 17:32:42 UTC) #4
rharding
10 years, 8 months ago (2013-08-28 17:45:37 UTC) #5
*** Submitted:

Adjust z-index to keep fullscreen above inspector

- The inspector is set to jump z-indexes up to 999 which causes it to overlay
the browser views all set to 1/2.
- I investigated the current 'stack' and most of the indexes are set to <20
and > 1000, so adjusted the inspectors to sit in the middle around 500, made
the browser views just over that at 600. 
- Verified all notifications, overlays, etc are > 600 (they're at 1000 and
		higher)

So general rule of thumb is basic things < 100, floating things at 500+,
overlay things > 1000.

Audit from grepping for z-indexes:

lib/views/browser/browser-icon.less:    z-index: 10;
lib/views/browser/bws-searchbox.less:      z-index: 15;
lib/views/browser/charm-full.less:        z-index: 10;
lib/views/browser/charm-token.less:            z-index: 10;
lib/views/browser/main.less:    z-index: 1;
lib/views/browser/main.less:    z-index: 2;
lib/views/browser/overlay-indicator.less:    z-index: 999;
lib/views/cookies.less:    z-index: 100;
lib/views/juju-inspector.less:            z-index: 1;
lib/views/juju-inspector.less:                z-index: 0;
lib/views/juju-inspector.less:                z-index: 2;
lib/views/stylesheet.less:    z-index: 10;
lib/views/stylesheet.less:    z-index: 9999;
lib/views/stylesheet.less:    z-index: 10;
lib/views/stylesheet.less: z-index: 100;
/** This is the inspector stuff here v **/
lib/views/stylesheet.less:    z-index: 999;
lib/views/stylesheet.less: z-index: 0;
lib/views/stylesheet.less: z-index: 2;
lib/views/stylesheet.less: z-index: 2;
lib/views/stylesheet.less:    z-index: 10000;
lib/views/stylesheet.less:    z-index: 10001;

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/13347043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b