Remove documentation for \instrumentSwitch

in favor of \set to set properties, and Textscripts for markup

[Trevor Daniels, 2014-08-31 08:06:46]

A few minor comments below, but I don't see
how we can just remove the instructions for
setting up InstrumentSwitch without some replacement.
InstrumentSwitch is used by \cueDuring and friends.

Trevor

https://codereview.appspot.com/133390043/diff/1/Documentation/notation/staff....
File Documentation/notation/staff.itely (right):

https://codereview.appspot.com/133390043/diff/1/Documentation/notation/staff....
Documentation/notation/staff.itely:979: \transposition c'
I think a piccolo sounds an octave higher than written,
and probably an octave higher than the notes as entered,
so this should be c''.  Might be worth a note that the
converse needs to be specified when reverting to flute
or other non-transposing instrument.

https://codereview.appspot.com/133390043/diff/1/Documentation/notation/staff....
Documentation/notation/staff.itely:992: \set Staff.shortInstrumentName = #"Clt."
Shouldn't these two lines be removed?

https://codereview.appspot.com/133390043/diff/1/Documentation/notation/staff....
Documentation/notation/staff.itely:1331: s1*0^\markup { \tiny "flute" }
I prefer <>

https://codereview.appspot.com/133390043/diff/1/Documentation/notation/staff....
Documentation/notation/staff.itely:1357: s1*0^\markup { \tiny "flute" }
I prefer <>

https://codereview.appspot.com/133390043/diff/1/Documentation/notation/staff....
Documentation/notation/staff.itely:1433: s1*0^\markup { \tiny "flute" }
I prefer <>

[Keith, 2014-08-31 18:37:19]

On Sun, 31 Aug 2014 01:06:46 -0700, <tdanielsmusic@googlemail.com> wrote:

> A few minor comments below, but I don't see
> how we can just remove the instructions for
> setting up InstrumentSwitch without some replacement.
> InstrumentSwitch is used by \cueDuring and friends.

\cueDuring itself does not use InstrumentSwitch; we were manually creating a
temporary cueVoice just before the \cueduring.   That takes the font-size from
CueVoice to use for the printed text, which is nice, but any overrides require a
non-obvious path through InstrumentSwitch
   \new CueVoice \with {
     \override InstrumentSwitch.direction = #DOWN
     \override InstrumentSwitch.font-shape = #'italic
     instrumentCueName = "Tuba" }
   \cueDuring "tuba" #DOWN { R1 g'2 bes' }

So the replacement for this use of InstrumentSwitch
    <>_\markup\italic\teeny"Tuba"
  is covered by the markup docmentation

The history is long.
I argued that the use of instrumentSwitch, to label the instrument playing cues,
was useless
  http://lists.gnu.org/archive/html/lilypond-user/2010-10/msg00148.html
and we removed it for some time,
 
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=4c1aa3b16f7b94c...
 
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=539934ff10d5ab0...

But we used a construction that used zero-length durations, which we later
removed
 
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=4ab6e4df934e57c...

Instead of <>^\markup, I went back to the instrumentCueName; the reason I gave
in the reitveld was complaints about the markup being tricky
  http://lists.gnu.org/archive/html/lilypond-user/2011-10/msg00118.html
That was dumb.  I had long-since stopped using instrumentCueName, so had
forgotten that it is much more tricky to use.

[t.daniels_treda.co.uk, 2014-08-31 21:49:03]

Keith, you wrote Sunday, August 31, 2014 7:36 PM
>

> On Sun, 31 Aug 2014 01:06:46 -0700, <tdanielsmusic@googlemail.com> wrote:
> 
>> A few minor comments below, but I don't see
>> how we can just remove the instructions for
>> setting up InstrumentSwitch without some replacement.
>> InstrumentSwitch is used by \cueDuring and friends.
> 
> \cueDuring itself does not use InstrumentSwitch; we were manually creating a
temporary cueVoice just before the \cueduring.   [snip]
> So the replacement for this use of InstrumentSwitch
>    <>_\markup\italic\teeny"Tuba"
>  is covered by the markup docmentation
> 
> The history is long.
[snip]

Ah, I'd totally forgotten that history.  As I'm not sure what I did this
morning
I have no chance of remembering things that happened 4 years ago.  Thanks
for the reminder.

So if you're happy now with using <> let's try again!

Trevor

[davide.liessi, 2014-08-31 22:55:11]

https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/st...
File Documentation/notation/staff.itely (right):

https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/st...
Documentation/notation/staff.itely:967: along with other settings as neded for
the new instrument.
neded -> needed

https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/st...
Documentation/notation/staff.itely:972: prepPiccolo =
<>^\markup\italic\line{"muta in Piccolo"}
Is '\line' needed here? I think that it can be omitted.
The same for 'prepFlute' at line 982.

Also, for coding style uniformity with the other '\markup...' commands in this
patch set, maybe this should be written '\markup { \italic "muta in Piccolo" }',
and similarly for lines 978, 982 and 988.

[dak, 2014-09-01 03:04:14]

On 2014/08/31 22:55:11, davide.liessi wrote:
>
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/st...
> File Documentation/notation/staff.itely (right):

>
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/st...
> Documentation/notation/staff.itely:972: prepPiccolo =
> <>^\markup\italic\line{"muta in Piccolo"}
> Is '\line' needed here? I think that it can be omitted.

<>^\markup \italic "muta in Piccolo"

would be fine and sufficient.  Omitting the spaces in that construct seems
cramped style, however.

> The same for 'prepFlute' at line 982.
> 
> Also, for coding style uniformity with the other '\markup...' commands in this
> patch set, maybe this should be written '\markup { \italic "muta in Piccolo"
}',
> and similarly for lines 978, 982 and 988.

I prefer not throwing redundant markup lists around.  \markup { ... } only works
because at top level markup, a markup list like { ... } is wrapped in an
additional \line layer.