Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 13338044: code review 13338044: go.crypto/ssh: introduce PrivateKey method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by hanwen-google
Modified:
6 years, 2 months ago
Reviewers:
jpsugar
CC:
agl1, jpsugar, jmp, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: introduce Signer method, an abstraction of private keys.

Patch Set 1 #

Patch Set 2 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Total comments: 12

Patch Set 4 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 7 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 9 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 10 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Total comments: 8

Patch Set 11 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Total comments: 17

Patch Set 12 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Patch Set 13 : diff -r c923f02daf74 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -251 lines) Patch
M ssh/certs.go View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -4 lines 0 comments Download
M ssh/client_auth_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 11 chunks +34 lines, -48 lines 0 comments Download
M ssh/common.go View 1 2 chunks +0 lines, -14 lines 0 comments Download
M ssh/example_test.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -2 lines 0 comments Download
M ssh/keys.go View 1 2 3 4 5 6 7 8 9 10 11 12 12 chunks +166 lines, -46 lines 0 comments Download
M ssh/keys_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +115 lines, -37 lines 0 comments Download
M ssh/server.go View 1 2 3 4 5 6 7 8 9 10 11 12 14 chunks +50 lines, -45 lines 0 comments Download
M ssh/test/keys_test.go View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -9 lines 0 comments Download
M ssh/test/test_unix_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +21 lines, -46 lines 0 comments Download

Messages

Total messages: 27
hanwen-google
Hello agl@golang.org, jpsugar@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
6 years, 2 months ago (2013-09-17 16:39:52 UTC) #1
jpsugar
https://codereview.appspot.com/13338044/diff/6001/ssh/client_auth_test.go File ssh/client_auth_test.go (right): https://codereview.appspot.com/13338044/diff/6001/ssh/client_auth_test.go#newcode120 ssh/client_auth_test.go:120: key := clientKeychain.keys[0].PublicKey() clientKeychain.Key(0) https://codereview.appspot.com/13338044/diff/6001/ssh/server.go File ssh/server.go (right): https://codereview.appspot.com/13338044/diff/6001/ssh/server.go#newcode65 ...
6 years, 2 months ago (2013-09-17 16:57:21 UTC) #2
hanwen-google
https://codereview.appspot.com/13338044/diff/6001/ssh/server.go File ssh/server.go (right): https://codereview.appspot.com/13338044/diff/6001/ssh/server.go#newcode65 ssh/server.go:65: // AddHostKey adds a private key as a host ...
6 years, 2 months ago (2013-09-17 19:13:25 UTC) #3
jpsugar
https://codereview.appspot.com/13338044/diff/6001/ssh/server.go File ssh/server.go (right): https://codereview.appspot.com/13338044/diff/6001/ssh/server.go#newcode69 ssh/server.go:69: if k.PublicKey().PrivateKeyAlgo() == key.PublicKey().PrivateKeyAlgo() { On 2013/09/17 19:13:25, hanwen-google ...
6 years, 2 months ago (2013-09-17 19:23:06 UTC) #4
jmp
https://codereview.appspot.com/13338044/diff/21001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/21001/ssh/keys.go#newcode231 ssh/keys.go:231: Sign(rand io.Reader, data []byte) ([]byte, error) I like the ...
6 years, 2 months ago (2013-09-18 04:07:50 UTC) #5
hanwen-google
On Wed, Sep 18, 2013 at 6:07 AM, <jonathan.mark.pittman@gmail.com> wrote: > > https://codereview.appspot.com/13338044/diff/21001/ssh/keys.go > File ...
6 years, 2 months ago (2013-09-18 11:05:45 UTC) #6
agl1
https://codereview.appspot.com/13338044/diff/35001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/35001/ssh/keys.go#newcode227 ssh/keys.go:227: // RawKey returns the underlying object, eg. *rsa.PrivateKey. Why ...
6 years, 2 months ago (2013-09-18 14:11:10 UTC) #7
hanwen-google
https://codereview.appspot.com/13338044/diff/35001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/35001/ssh/keys.go#newcode227 ssh/keys.go:227: // RawKey returns the underlying object, eg. *rsa.PrivateKey. On ...
6 years, 2 months ago (2013-09-18 14:31:41 UTC) #8
hanwen-google
also, what about SetRSAPrivateKey ? It's now a wrapper for ParsePrivateKey + AddHostKey. We could ...
6 years, 2 months ago (2013-09-18 14:35:48 UTC) #9
jmp
> I'm not sure I agree. We'd then have to make signature type public, > ...
6 years, 2 months ago (2013-09-18 15:09:49 UTC) #10
hanwen-google
On Wed, Sep 18, 2013 at 5:09 PM, <jonathan.mark.pittman@gmail.com> wrote: >> I'm not sure I ...
6 years, 2 months ago (2013-09-18 15:21:26 UTC) #11
hanwen-google
On Wed, Sep 18, 2013 at 4:31 PM, <hanwen@google.com> wrote: > > https://codereview.appspot.com/13338044/diff/35001/ssh/keys.go > File ...
6 years, 2 months ago (2013-09-18 15:31:30 UTC) #12
jpsugar
On 2013/09/18 15:31:30, hanwen-google wrote: > Come to think of it, do we need PublicKey.RawKey() ...
6 years, 2 months ago (2013-09-18 17:47:20 UTC) #13
jpsugar
https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go#newcode223 ssh/keys.go:223: type PrivateKey interface { So is this Signer now? ...
6 years, 2 months ago (2013-09-18 19:16:59 UTC) #14
jmp
https://codereview.appspot.com/13338044/diff/31001/ssh/server.go File ssh/server.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/server.go#newcode322 ssh/server.go:322: return serializeSignature(k.PublicKey().PublicKeyAlgo(), sig), nil The private key is used ...
6 years, 2 months ago (2013-09-18 20:25:07 UTC) #15
jpsugar
https://codereview.appspot.com/13338044/diff/31001/ssh/server.go File ssh/server.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/server.go#newcode322 ssh/server.go:322: return serializeSignature(k.PublicKey().PublicKeyAlgo(), sig), nil On 2013/09/18 20:25:08, jmp wrote: ...
6 years, 2 months ago (2013-09-18 21:23:14 UTC) #16
hanwen-google
On 2013/09/18 17:47:20, jpsugar wrote: > On 2013/09/18 15:31:30, hanwen-google wrote: > > Come to ...
6 years, 2 months ago (2013-09-19 12:01:34 UTC) #17
hanwen-google
https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go#newcode223 ssh/keys.go:223: type PrivateKey interface { On 2013/09/18 19:17:00, jpsugar wrote: ...
6 years, 2 months ago (2013-09-19 12:24:47 UTC) #18
jmp
https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go#newcode223 ssh/keys.go:223: type PrivateKey interface { On 2013/09/19 12:24:48, hanwen-google wrote: ...
6 years, 2 months ago (2013-09-19 13:58:27 UTC) #19
hanwen-google
On Thu, Sep 19, 2013 at 3:58 PM, <jonathan.mark.pittman@gmail.com> wrote: > > https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go > File ...
6 years, 2 months ago (2013-09-19 14:07:14 UTC) #20
jmp
On 2013/09/19 14:07:14, hanwen-google wrote: > On Thu, Sep 19, 2013 at 3:58 PM, <mailto:jonathan.mark.pittman@gmail.com> ...
6 years, 2 months ago (2013-09-19 17:14:27 UTC) #21
hanwen-google
On Thu, Sep 19, 2013 at 7:14 PM, <jonathan.mark.pittman@gmail.com> wrote: > On 2013/09/19 14:07:14, hanwen-google ...
6 years, 2 months ago (2013-09-19 17:25:36 UTC) #22
jpsugar
https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go#newcode223 ssh/keys.go:223: type PrivateKey interface { On 2013/09/19 13:58:27, jmp wrote: ...
6 years, 2 months ago (2013-09-19 17:32:09 UTC) #23
hanwen-google
https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/13338044/diff/31001/ssh/keys.go#newcode223 ssh/keys.go:223: type PrivateKey interface { On 2013/09/19 17:32:09, jpsugar wrote: ...
6 years, 2 months ago (2013-09-19 17:51:39 UTC) #24
jpsugar
LGTM
6 years, 2 months ago (2013-09-19 18:30:20 UTC) #25
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=a55cb07dff16&repo=crypto *** go.crypto/ssh: introduce Signer method, an abstraction of private keys. R=agl, ...
6 years, 2 months ago (2013-09-19 18:45:51 UTC) #26
hanwen-google
6 years, 2 months ago (2013-09-20 11:55:25 UTC) #27
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b