Issue 13336043: state/apiserver: make ServerError work properly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13336043: state/apiserver: make ServerError work properly

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rog

Modified:
10 years, 8 months ago

Reviewers:
mp+182562, jameinel, fwereade

Visibility:
Public.

Description

state/apiserver: make ServerError work properly It didn't work if the error type was non-comparable. https://code.launchpad.net/~rogpeppe/juju-core/377-fix-server-error/+merge/182562 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: make ServerError work properly #

Patch Set 3 : state/apiserver: make ServerError work properly #

Patch Set 4 : state/apiserver: make ServerError work properly #

Total comments: 2

Patch Set 5 : state/apiserver: make ServerError work properly #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/apiserver/common/errors.go	View	1 2 3 4	2 chunks	+13 lines, -2 lines	0 comments	Download
M	state/apiserver/common/errors_test.go	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

jameinel

Thanks for moving the tests. I have: https://codereview.appspot.com/13338043 For the other way of fixing this. ...

10 years, 8 months ago (2013-08-28 09:02:40 UTC) #4

rog

https://codereview.appspot.com/13336043/diff/8001/state/apiserver/common/errors.go File state/apiserver/common/errors.go (right): https://codereview.appspot.com/13336043/diff/8001/state/apiserver/common/errors.go#newcode68 state/apiserver/common/errors.go:68: func ServerError(err error) (apiError *params.Error) { On 2013/08/28 09:02:40, ...

10 years, 8 months ago (2013-08-28 09:12:44 UTC) #5

LGTM also fwiw

Expand All Messages | Collapse All Messages