Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(609)

Issue 13338043: state/apiserver/common: handle unhashable types

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jameinel
Modified:
10 years, 8 months ago
Reviewers:
mp+182564
Visibility:
Public.

Description

state/apiserver/common: handle unhashable types See bug #1217760. Essentially we sometimes get errors that can't be hashed, and it was causing us to panic() rather than treat the error like we treat all other unknown errors. Roger has a different way of handling it using defer and recover. We have a map which I like, but this map isn't intended to become public or extensible. So the easy path is to just fold it into the switch. https://code.launchpad.net/~jameinel/juju-core/unhashable-errors-1217760/+merge/182564 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -15 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/common/errors.go View 2 chunks +25 lines, -14 lines 0 comments Download
M state/apiserver/common/errors_test.go View 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 1
jameinel
10 years, 8 months ago (2013-08-28 08:58:38 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b