code review 13335050: doc/go1.2.txt: crypto/{x509,tls} changes

doc/go1.2.txt: crypto/{x509,tls} changes

[agl1, 2013-09-03 15:31:17]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-09-03 15:32:39]

LGTM

I think multiple lines for crypto/tls is also okay, as is done elsewhere in
the file.



On Tue, Sep 3, 2013 at 8:31 AM, <agl@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> doc/go1.2.txt: crypto/{x509,tls} changes
>
> Please review this at
https://codereview.appspot.**com/13335050/<https://codereview.appspot.com/133...
>
> Affected files:
>   M doc/go1.2.txt
>
>
> Index: doc/go1.2.txt
> ==============================**==============================**=======
> --- a/doc/go1.2.txt
> +++ b/doc/go1.2.txt
> @@ -40,7 +40,8 @@
>  crypto/sha1: Sum function to simplify hashing (CL 10571043).
>  crypto/sha256: Sum256 and Sum224 functions to simplify hashing (CL
> 10629043).
>  crypto/sha512: Sum512 and Sum384 functions to simplify hashing (CL
> 10630043).
> -crypto/tls: add support for TLS 1.1. (CL 7872043).
> +crypto/x509: add support for reading and writing arbitrary extensions (CL
> 12056043).
> +crypto/tls: add support for TLS 1.1, 1.2 and AES-GCM. (CL 7872043,
> 10762044 and 13249044).
>  database/sql: add SetMaxOpenConns method on DB (CL 10726044).
>  encoding: new package defining generic encoding interfaces (CL 12541051).
>  encoding/csv: always allow trailing commas (CL 12294043).
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[agl1, 2013-09-03 20:19:08]

On Tue, Sep 3, 2013 at 11:32 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> I think multiple lines for crypto/tls is also okay, as is done elsewhere in
> the file.

In this case, the changes are all closely related (getting AES-GCM was
the point, the other features were required for that), so I think a
single line is right.


Cheers

AGL

[agl1, 2013-09-03 20:19:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=6adf94d423d6 ***

doc/go1.2.txt: crypto/{x509,tls} changes

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13335050